diff options
Diffstat (limited to 'src/libaudcore/equalizer.cc')
| -rw-r--r-- | src/libaudcore/equalizer.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/libaudcore/equalizer.cc b/src/libaudcore/equalizer.cc index 7cc6aa8..3d6b816 100644 --- a/src/libaudcore/equalizer.cc +++ b/src/libaudcore/equalizer.cc @@ -187,6 +187,11 @@ EXPORT void aud_eq_set_band(int band, double value) { assert(band >= 0 && band < AUD_EQ_NBANDS); + /* This read-modify-write sequence is technically not thread-safe, + * since it could clobber concurrent changes to other EQ bands. In + * practice, this should not be an issue, since no one updating EQ + * settings from multiple threads should be expecting consistent + * results anyway). */ double values[AUD_EQ_NBANDS]; aud_eq_get_bands(values); values[band] = value; |