summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Wilson <chris+github@qwirx.com>2013-09-20 15:16:25 +0000
committerChris Wilson <chris+github@qwirx.com>2013-09-20 15:16:25 +0000
commit0540ad493355d0ab5dc56354a43fccd8b6adea5e (patch)
tree714626bd06103ad48124725b43d053c6f02dc87c
parent42bb8be07da8ddab7a11848b88ffea3e47ccb7dd (diff)
Add a comment about removing one RaidFileWrite constructor.
-rw-r--r--lib/raidfile/RaidFileWrite.h11
1 files changed, 11 insertions, 0 deletions
diff --git a/lib/raidfile/RaidFileWrite.h b/lib/raidfile/RaidFileWrite.h
index bf3c8cc3..e2887167 100644
--- a/lib/raidfile/RaidFileWrite.h
+++ b/lib/raidfile/RaidFileWrite.h
@@ -27,7 +27,18 @@ class RaidFileDiscSet;
class RaidFileWrite : public IOStream
{
public:
+ // TODO FIXME we should remove this constructor, and ensure that
+ // anyone who writes to a RaidFile knows what the reference count
+ // is before doing so. That requires supporting regenerating the
+ // reference count database in BackupStoreCheck, and using a real
+ // database instead of an in-memory array in HousekeepStoreAccount,
+ // and supporting multiple databases at a time (old and new) in
+ // BackupStoreRefCountDatabase, and I don't have time to make those
+ // changes right now. We may even absolutely need to have a full
+ // reference database, not just reference counts, to implement
+ // snapshots.
RaidFileWrite(int SetNumber, const std::string &Filename);
+
RaidFileWrite(int SetNumber, const std::string &Filename, int refcount);
~RaidFileWrite();
private: