Create new refcount database atomically during account check.

Use a temporary refcount db for check instead of an in-memory vector. This
avoid the memory usage problems created by using the vector on large accounts,
but may require us to improve the efficiency of the refcount database itself
to avoid large numbers of small I/O operations. That is very doable now that
we're using a class for it.

Fix some inconsistencies and mistakes in handling reference counts and
info counters during account checks (more to come).

1 files changed, 1 insertions, 4 deletions

diff --git a/lib/backupstore/BackupStoreAccounts.cpp b/lib/backupstore/BackupStoreAccounts.cpp
index d9efcd5d..6a4d846c 100644
--- a/lib/backupstore/BackupStoreAccounts.cpp
+++ b/lib/backupstore/BackupStoreAccounts.cpp
@@ -120,10 +120,7 @@ void BackupStoreAccounts::Create(int32_t ID, int DiscSet, int64_t SizeSoftLimit,
 		info->Save();
 
 		// Create the refcount database
-		BackupStoreRefCountDatabase::CreateNew(Entry);
-		std::auto_ptr<BackupStoreRefCountDatabase> refcount(
-			BackupStoreRefCountDatabase::Load(Entry, false));
-		refcount->AddReference(BACKUPSTORE_ROOT_DIRECTORY_ID);
+		BackupStoreRefCountDatabase::Create(Entry)->Commit();
 	}
 
 	// As the original user...