Always flush any incoming stream on server side.

Otherwise the protocol might be broken and can't be used any more, even if
we made an effort to return an Error reply instead of throwing an exception.

This used to not be a problem because an Error reply would terminate the
connection anyway, but it no longer does. So if the client also didn't
terminate, but tried to handle the exception and keep using the connection,
then it might find that its next command fails because the protocol is broken.

1 files changed, 6 insertions, 0 deletions

diff --git a/lib/common/SelfFlushingStream.h b/lib/common/SelfFlushingStream.h
index 36e9a4d3..6865ab96 100644
--- a/lib/common/SelfFlushingStream.h
+++ b/lib/common/SelfFlushingStream.h
@@ -33,6 +33,12 @@ public:
 	
 	~SelfFlushingStream()
 	{
+		if(StreamDataLeft())
+		{
+			BOX_WARNING("Not all data was read from stream, "
+				"discarding the rest");
+		}
+
 		Flush();
 	}