| Commit message (Collapse) | Author | Age |
... | |
|
|
|
| |
This reverts commit 59c3fdf8be1def3f237a4b51eb27773b4f42bbcd.
|
|
|
|
|
|
| |
Being able to see the actual and expected values helps with debugging.
More cleanup of comments.
|
| |
|
| |
|
|
|
|
| |
Move ExpectedRefCounts definition to where it's needed.
|
|
|
|
| |
Saves ~2 lines each time it's used. And we use it a lot in testbackupstore.
|
| |
|
|
|
|
| |
Backported from new testbackupstore, to reduce diff.
|
|
|
|
|
|
| |
Will help to ensure that individual test cases run properly, even if a
previous test didn't clear up after itself. Splitting up testbackupstore
into idempotent testcases is coming soon.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
There could be many reasons for this, including an invalid object being
deleted during the previous check run. And it's definitely not serious.
|
|
|
|
|
| |
Also pass the actual reference count of an object to RaidFileWrite instead
of assuming that it's zero, to avoid accidentally deleting a referenced object.
|
|
|
|
|
|
| |
Fix test/common memory leak checks now that MemBlockStream allocates another
block.
|
| |
|
| |
|
|
|
|
| |
Allows aborting tests from any depth of function calls.
|
| |
|
|
|
|
|
|
| |
Useful for sending simple string messages through Protocols or writing them
to streams. Takes a copy of the string, so you don't need to worry about object
lifetime.
|
|
|
|
|
|
|
|
| |
Track them as not leaks, and suppress warnings about realloc() and free() on
these blocks, because they are actually tracked.
Add missing "throw (std::bad_alloc)" to "operator new" to silence warnings
from the llvm compiler.
|
|
|
|
|
| |
Backport a few new functions to simplify tests.
|
|
|
|
| |
Adding and deleting files was not always accounted properly before.
|
| |
|
| |
|
|
|
|
| |
It's used in several places, and about to be one more.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Will hopefully prevent future confusion about the meaning of this info
variable.
|
|
|
|
|
|
|
| |
Until the groundwork is prepared by changing Protocol's use of IOStream to
SocketStream.
This reverts commit 78531354753f3ce9bb3ef1d906b2aeaac5b73d58.
|
|
|
|
|
|
| |
We don't have a test for it yet, and won't until snapshots are implemented,
but it's a bad idea to merge patches to remove an old version when another
directory is still holding a reference to the patch.
|
|
|
|
|
|
| |
Fix accounting for current, old and deleted files and blocks. Previously there
was confusion over the meaning of NumFiles, now it's defined to mean the number
of current files (neither old nor deleted), similar to BlocksInCurrentFiles.
|
|
|
|
| |
that we're doing so.
|
|
|
|
| |
One less reason to hang onto a Stream reference, that will go away soon.
|
| |
|
|
|
|
|
|
| |
Sometimes useful to replace instead of appending to the current tag.
The old tag will be reinstated when the tagger is destroyed.
|
|
|
|
|
| |
This is useful for disambiguating messages coming from different parts of the
application when looking at console output.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Caused by removal of BackupStoreRefCountDatabase::CreateForRegeneration.
It's not safe to do this in housekeeping anyway, because it might not
complete the scan, leaving an incomplete database, that might persuade
BackupStoreContext that it's OK to delete an object that still really has
references to it.
If your refcount db disappears or is damaged, you need to run a check fix.
|
|
|
|
|
|
|
|
|
|
|
| |
Use a temporary refcount db for check instead of an in-memory vector. This
avoid the memory usage problems created by using the vector on large accounts,
but may require us to improve the efficiency of the refcount database itself
to avoid large numbers of small I/O operations. That is very doable now that
we're using a class for it.
Fix some inconsistencies and mistakes in handling reference counts and
info counters during account checks (more to come).
|
|
|
|
|
| |
Caused by premature switch from GetNumFiles to GetNumCurrentFiles.
|
|
|
|
|
|
| |
Fix erroneous detection of leaked file descriptors by closing syslog before
compiling the initial list of file descriptors.
|
| |
|
|
|
|
|
| |
Allows us to get information about the account that's not available
using the old AccountUsage command. Currently only used in tests.
|
|
|
|
| |
Makes code easier to read.
|
| |
|