| Commit message (Collapse) | Author | Age |
|
|
|
| |
We don't really need these, so clean up by removing them.
|
|
|
|
|
|
|
|
| |
Conflicts:
bin/bbackupd/BackupDaemon.cpp
bin/bbackupd/BackupDaemon.h
test/bbackupd/testbbackupd.cpp
|
|
|
|
| |
To help with debugging.
|
|
|
|
|
|
| |
Conflicts:
bin/bbackupd/BackupClientDirectoryRecord.cpp
|
| |
|
|
|
|
|
| |
Useful to help debug problems such as invalid file headers when the source
of the stream might not be too obvious.
|
|
|
|
| |
This is hopefully the cause of the segfaults reported by Brendon Baumgartner.
|
| |
|
|
|
|
|
| |
Thanks to Brendon Baumgartner for the report on the mailing list, and for
helping to diagnose the problem.
|
| |
|
|
|
|
|
|
| |
Was having problems compiling on MinGW x86_64, with the scripts failing to
properly detect the platform and recommending upgrading them. It may not
have fixed the problem, but doesn't seem like a bad idea.
|
|
|
|
|
|
|
|
|
| |
Will hopefully help to debug Brendon Baumgartner's issue with backups not
completing and repeating over and over, due to this error:
> Apr 18 11:14:09 hosting bbackupd[18990]: WARNING: Exception thrown:
> ServerException(Protocol_BadUsage) (Sending a stream with a definite
> size of zero is not allowed in the protocol) at Protocol.cpp:703
|
|
|
|
| |
Was accidentally removed by the refactoring of the backup idle loop.
|
| |
|
| |
|
|
|
|
|
| |
Otherwise it interrupts us needlessly while we're sleeping waiting for
the next backup.
|
| |
|
| |
|
|
|
|
|
| |
Enables bbackupd to be stopped, reloaded or status queried while scanning
a large directory.
|
| |
|
| |
|
|
|
|
| |
immediately after the end of the current one.
|
|
|
|
|
|
|
|
| |
Add helpful debugging messages about why the decision was taken to sleep
or start a backup, and how long the system will wait until the next
backup.
Flatten the code to avoid the double loop.
|
| |
|
|
|
|
| |
Caused an assertion failure and crash.
|
|
|
|
|
|
|
| |
If libedit is installed then -ledit will be detected and added to the link
line, which makes the test for getpeereid pass. Then SocketStream.cpp tries
to use it, but that won't work unless we include bsd/unistd.h where the
prototype is declared.
|
|
|
|
| |
Otherwise all callers need to initialise them, or get false positives.
|
| |
|
|
|
|
|
| |
Makes the daemon responsive to polling and commands, even during a file
upload operation.
|
|
|
|
| |
Enables all standard logging options and reduces code duplication.
|
|
|
|
| |
Allows command-line tools to reuse the same option processing.
|
|
|
|
|
| |
Report the exception message details if it's a BoxException, so it's more
user friendly.
|
|
|
|
|
| |
Use the standard macros to report file error messages in the standard
format, including a filename and message in the exception.
|
|
|
|
|
| |
Allows polling the daemon to see if it's running, without telling it to
actually do anything.
|
| |
|
|
|
|
| |
Useful in testing whether code logs the expected messages or not.
|
|
|
|
| |
This is very useful with the forthcoming Capture logger.
|
|
|
|
|
| |
It's incompatible with having a logger that logs everything, regardless of
the global log level.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When entries are added to a directory by a command (BackupStoreContext),
and when entries are removed from a directory (by housekeeping), update the
parent directory's entry for us if our size has changed.
Make BackupStoreCheck check for, report and fix errors when directory entries
are directories and the size is wrong (as well as files).
Conflicts:
test/backupstore/testbackupstore.cpp
Fix directories loaded without size being set, leading to warnings later.
We can't check that the old size in the parent entry matched the old real size
of the directory, unless we set the old real size in the directory.
And we don't need to pass the old directory size to
HousekeepStoreAccount::DeleteFile, because we can get it from the directory
itself.
|
|
|
|
|
|
|
|
| |
This is useful to return from a test if an assertion/check fails, instead of
throwing an exception.
Also add logging of the actual error code received (with name) to
TEST_COMMAND_RETURNS_ERROR(_OR).
|
| |
|
| |
|
|
|
|
| |
Returns the number of errors found and fixed.
|
|
|
|
| |
It was hardcoded to 0x01234567 due to a copy and paste error.
|
|
|
|
|
|
|
| |
Passing the wrong object ID would just result in an assertion being thrown
(in debug builds) or silently doing the wrong thing (in release builds). I
can't see any useful use for this extra parameter, since we can get the
container ID from the directory anyway.
|
|
|
|
|
|
|
|
|
| |
Allows retrieving the error message for a given code, when we no longer have
the protocol object handy.
Conflicts:
lib/server/makeprotocol.pl.in
|
| |
|
|
|
|
|
| |
An incorrect comment led me to believe that this parameter was the new
directory's AttributesModTime, but actually it was its hash.
|
|
|
|
|
|
|
|
|
| |
If the old refcount database was shorter than the new one, then we could end
up trying to access a nonexistent refcount, triggering an exception, which
prevented all comparison of the old and new refcount databases.
Also, from now on, a mismatch between old and new refcounts is treated as a
housekeeping error, which is detectable in tests.
|
| |
|