Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | Whitespace, comments and log messages cleanups. | Chris Wilson | 2014-03-02 |
| | |||
* | Make Protocol take control of the socket object passed in. | Chris Wilson | 2014-03-01 |
| | | | | | | | | | | | | | We pass a std::auto_ptr<SocketStream> to every Protocol subclass when we construct it, and it takes control of this object. This reduces the risk of: * accidentally reusing the same SocketStream for multiple Protocols (it happened to me in testbackupstore); * holding onto a reference to the SocketStream; * allowing a locally-scoped SocketStream to go out of scope and be released while still being referenced by a live Protocol. | ||
* | Simplify exception handling by using std::auto_ptr. | Chris Wilson | 2014-02-27 |
| | | | | | Will result in the directory automatically being freed, whether or not an exception occurs. | ||
* | Fix crash in BackupStoreContext with no HousekeepingInterface pointer. | Chris Wilson | 2014-02-27 |
| | | | | | | Rename mrDaemon to mpHousekeeping and make it a pointer, so that it can officially be NULL, and don't crash if it is, and we fail to get a lock on the account. | ||
* | Fix memory leak in bbackupquery readline completion. | Chris Wilson | 2014-02-27 |
| | |||
* | Fix unnecessarily verbose log message about SyncAllowScript. | Chris Wilson | 2014-02-10 |
| | |||
* | Fix use of wrong config file in bbstoreaccounts. | Chris Wilson | 2014-02-09 |
| | |||
* | Revert "Get backup connection stats from BackupProtocolServer." | Chris Wilson | 2014-02-09 |
| | | | | | | | Until the groundwork is prepared by changing Protocol's use of IOStream to SocketStream. This reverts commit 78531354753f3ce9bb3ef1d906b2aeaac5b73d58. | ||
* | Get backup connection stats from BackupProtocolServer. | Chris Wilson | 2014-02-09 |
| | | | | One less reason to hang onto a Stream reference, that will go away soon. | ||
* | Print a newline when user presses Ctrl+D at bbackupquery prompt. | Chris Wilson | 2014-02-07 |
| | | | | Makes the output look a little nicer as bbackupquery dies. | ||
* | Fix bbackupquery accepting a command starting with options. | Chris Wilson | 2014-02-07 |
| | | | | | | | This should never have been a valid command, but was accepted before, and silently ignored because it was treated as an empty command. This obscured bad quoting of bbackupquery command-line arguments, allowing commands to appear to work, but not do what you expected. | ||
* | Split bbstoreaccounts commands out into a separate class. | Chris Wilson | 2014-02-07 |
| | | | | | Allows us to call them from tests without shelling out, making debugging easier. | ||
* | Show more details when bbackupquery command parsing fails | Chris Wilson | 2014-02-07 |
| | |||
* | Fix getopt header confusion. | Chris Wilson | 2013-09-30 |
| | | | | | | | | Our copy of getopt.h in lib/win32 was beating the system getopt.h in the search path, and providing different definitions, which clang picked up. Renamed our getopt.h to bsd_getopt.h, and added a box_getopt.h to decide whether to include this one instead of the system getopt.h. | ||
* | Clang complains that "enabled" is not initialised. | Chris Wilson | 2013-09-28 |
| | | | | | | | It doesn't know that we call a function that exits the program prematurely. In any case, this patch stops it from complaining. | ||
* | Pass std::auto_ptr objects to Protocol for upload. | Chris Wilson | 2013-08-22 |
| | | | | | | | | | | | Passing raw pointers is bad C++ style, and dangerous, because Protocol will free the passed-in pointers after uploading them, so we should not keep using them. Reduce code duplication in BackupClientDirectoryRecord patch/normal upload. Return a std::auto_ptr<BackupStoreFileEncodeStream> instead of a std::auto_ptr<IOStream> from BackupStoreFile::EncodeFile* functions. | ||
* | Fix failure to list files properly when not using a console on Win32 | Chris Wilson | 2012-11-27 |
| | | | | | (e.g. from Cygwin command prompt). | ||
* | Log reason for housekeeping, or not (timer status). | Chris Wilson | 2012-11-27 |
| | |||
* | Add a helper in BackupStoreAccounts to get a write lock on an account. | Chris Wilson | 2012-11-18 |
| | | | | | | Use it in two places to simplify code (not in BackupStoreContext yet, because that wants to communicate with HK process as well). | ||
* | Fix duplicate tagging of housekeeping messages. | Chris Wilson | 2012-11-17 |
| | |||
* | Use more efficient direct reset of Timers instead of assignment. | Chris Wilson | 2012-11-17 |
| | |||
* | Fix account deletion on Windows by removing write lock before deleting | Chris Wilson | 2012-11-17 |
| | | | | | files. | ||
* | Fix compile failure due to removal of fields from BackupClientContext. | Chris Wilson | 2012-11-08 |
| | |||
* | Replace magic number 1000 with MILLI_SEC_IN_SEC when initialising timers. | Chris Wilson | 2012-11-07 |
| | | | | | Add the start of ExperimentalSnapshotMode support. | ||
* | Refactor bbstoreaccounts code to reduce duplication. | Chris Wilson | 2012-10-22 |
| | | | | | | Add a bbstoreaccounts command to change the value of the AccountEnabled flag, and print its value in "bbstoreaccounts info" output. | ||
* | Fix compile error on MSVC due to attempt to convert a std::list::iterator | Chris Wilson | 2012-07-20 |
| | | | | | to a std::vector::iterator. | ||
* | Throw an exception if we fail to open inode database, even in release builds. | Chris Wilson | 2012-06-29 |
| | |||
* | Add housekeep command to bbstoreaccounts to run housekeeping right now. | Chris Wilson | 2012-06-29 |
| | |||
* | bbackupquery readline improvements, thanks to Paolo Tosco: | Chris Wilson | 2012-05-26 |
| | | | | | | | | | | | Automatically quote filenames including spaces on the readline input. Ignore empty commands, don't generate a parse error message. Close cleanly and quietly when EOF is input (Ctrl+D). Simplify interactive mode code in bbackupquery. | ||
* | Tag housekeeping logging with the account number and name. | Chris Wilson | 2012-05-03 |
| | |||
* | Use the correct default config file for bbstored, thanks Pete! | Chris Wilson | 2012-05-03 |
| | |||
* | Make BackupStoreDaemon::RunHousekeepingIfNeeded public to allow tests to ↵ | Chris Wilson | 2012-04-28 |
| | | | | call it. | ||
* | Change BackupQueries List() to use C++ streams for output. | Chris Wilson | 2012-04-28 |
| | |||
* | Allow BackupDaemon user to reset state for testing. | Chris Wilson | 2012-04-28 |
| | |||
* | Treat corrupt filenames (not decryptable) as not existing, so that | Chris Wilson | 2012-04-15 |
| | | | | | | | | | the client will flag them for deletion, and the store will eventually prune them. We could probably recover better by flagging them for immediate deletion (Remove_ASAP) but this is a better-tested code path. Remove unused variable hasMultipleHardLinks. | ||
* | Use C++ string instead of converting to C string and back. | Chris Wilson | 2012-04-15 |
| | |||
* | Fix a memory leak when TcpNice is disabled. | Chris Wilson | 2012-04-11 |
| | |||
* | Improve logging when decrypting a filename fails during UpdateItems(). | Chris Wilson | 2012-04-11 |
| | |||
* | Really fix compile error this time. | Chris Wilson | 2012-03-16 |
| | |||
* | Add support for SyncAllowScript to set maximum upload bandwidth dynamically. | Chris Wilson | 2012-03-10 |
| | |||
* | Add experimental "TCP Nice" mode, disabled by default. | Chris Wilson | 2012-02-12 |
| | |||
* | Fix compile error, thanks to James and Buildbot :) | Chris Wilson | 2012-02-02 |
| | |||
* | If a location was not present (on disk) when bbackupd started, don't forget | Chris Wilson | 2012-02-02 |
| | | | | | about it but start backing it up if it appears subsequently. | ||
* | Log which account we're housekeeping, to help debug housekeeping ↵ | Chris Wilson | 2012-02-02 |
| | | | | crashes/failures. | ||
* | Add missing space in log message for readability. | Chris Wilson | 2012-02-02 |
| | |||
* | Add missing typedef to allow use of ReturnCode enum. | Chris Wilson | 2012-01-22 |
| | |||
* | Allow getting the object ID out from a BackupClientDirectoryRecord. | Chris Wilson | 2012-01-22 |
| | |||
* | Add remote host and port to post-login login message, requested by Pete Jalajas. | Chris Wilson | 2011-12-13 |
| | |||
* | Log the account name with connections, disconnections and statistics, ↵ | Chris Wilson | 2011-12-12 |
| | | | | requested by Pete Jalajas. | ||
* | Delete any incomplete ID map database that we find, so that we can start | Chris Wilson | 2011-10-25 |
| | | | | | | afresh with a new one, should solve most corrupt database errors such as the ones reported by Achim. |