| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
| |
Similar to TEST_COMMAND_RETURNS_ERROR_OR, but allows any command or sequence
to cause the error, without direct access to the command message.
Refactor so that TEST_COMMAND_RETURNS_ERROR_OR calls TEST_PROTOCOL_ERROR_OR
to make the assertion on the last error seen by the protocol.
|
| |
|
|
| |
We don't really need these, so clean up by removing them.
|
| |
|
|
|
|
|
|
| |
Conflicts:
bin/bbackupd/BackupDaemon.cpp
bin/bbackupd/BackupDaemon.h
test/bbackupd/testbbackupd.cpp
|
| |
|
|
|
|
| |
Conflicts:
bin/bbackupd/BackupClientDirectoryRecord.cpp
|
| | |
|
| |
|
|
|
| |
Useful to help debug problems such as invalid file headers when the source
of the stream might not be too obvious.
|
| |
|
|
| |
This is hopefully the cause of the segfaults reported by Brendon Baumgartner.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Will hopefully help to debug Brendon Baumgartner's issue with backups not
completing and repeating over and over, due to this error:
> Apr 18 11:14:09 hosting bbackupd[18990]: WARNING: Exception thrown:
> ServerException(Protocol_BadUsage) (Sending a stream with a definite
> size of zero is not allowed in the protocol) at Protocol.cpp:703
|
| |
|
|
|
|
|
| |
If libedit is installed then -ledit will be detected and added to the link
line, which makes the test for getpeereid pass. Then SocketStream.cpp tries
to use it, but that won't work unless we include bsd/unistd.h where the
prototype is declared.
|
| | |
|
| |
|
|
|
| |
Makes the daemon responsive to polling and commands, even during a file
upload operation.
|
| |
|
|
| |
Allows command-line tools to reuse the same option processing.
|
| |
|
|
|
| |
Report the exception message details if it's a BoxException, so it's more
user friendly.
|
| |
|
|
|
| |
Use the standard macros to report file error messages in the standard
format, including a filename and message in the exception.
|
| | |
|
| |
|
|
| |
Useful in testing whether code logs the expected messages or not.
|
| |
|
|
| |
This is very useful with the forthcoming Capture logger.
|
| |
|
|
|
| |
It's incompatible with having a logger that logs everything, regardless of
the global log level.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When entries are added to a directory by a command (BackupStoreContext),
and when entries are removed from a directory (by housekeeping), update the
parent directory's entry for us if our size has changed.
Make BackupStoreCheck check for, report and fix errors when directory entries
are directories and the size is wrong (as well as files).
Conflicts:
test/backupstore/testbackupstore.cpp
Fix directories loaded without size being set, leading to warnings later.
We can't check that the old size in the parent entry matched the old real size
of the directory, unless we set the old real size in the directory.
And we don't need to pass the old directory size to
HousekeepStoreAccount::DeleteFile, because we can get it from the directory
itself.
|
| |
|
|
|
|
|
|
| |
This is useful to return from a test if an assertion/check fails, instead of
throwing an exception.
Also add logging of the actual error code received (with name) to
TEST_COMMAND_RETURNS_ERROR(_OR).
|
| | |
|
| |
|
|
| |
Returns the number of errors found and fixed.
|
| |
|
|
| |
It was hardcoded to 0x01234567 due to a copy and paste error.
|
| |
|
|
|
|
|
| |
Passing the wrong object ID would just result in an assertion being thrown
(in debug builds) or silently doing the wrong thing (in release builds). I
can't see any useful use for this extra parameter, since we can get the
container ID from the directory anyway.
|
| |
|
|
|
|
|
|
|
| |
Allows retrieving the error message for a given code, when we no longer have
the protocol object handy.
Conflicts:
lib/server/makeprotocol.pl.in
|
| | |
|
| |
|
|
|
| |
An incorrect comment led me to believe that this parameter was the new
directory's AttributesModTime, but actually it was its hash.
|
| |
|
|
|
|
|
|
|
| |
If the old refcount database was shorter than the new one, then we could end
up trying to access a nonexistent refcount, triggering an exception, which
prevented all comparison of the old and new refcount databases.
Also, from now on, a mismatch between old and new refcounts is treated as a
housekeeping error, which is detectable in tests.
|
| | |
|
| |
|
|
|
| |
Using methods instead of macros where possible makes debugging easier.
Especially long macros like this one.
|
| |
|
|
|
|
|
|
|
|
| |
Otherwise the protocol might be broken and can't be used any more, even if
we made an effort to return an Error reply instead of throwing an exception.
This used to not be a problem because an Error reply would terminate the
connection anyway, but it no longer does. So if the client also didn't
terminate, but tried to handle the exception and keep using the connection,
then it might find that its next command fails because the protocol is broken.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
When a command fails with an error, and CheckReply throws an exception, the
mStreamsToSend were not deleted.
|
| |
|
|
|
|
|
|
|
|
| |
Helps with debugging ConnectionException::Protocol_StreamWhenObjExpected and
ConnectionException::Protocol_ObjWhenStreamExpected errors, which may be caused
by a command returning an error message and failing to consume any uploaded
streams first.
Add extra debugging in ProtocolLocal objects to detect when this happens
during the command itself, which helps with debugging.
|
| | |
|
| |
|
|
| |
Just like adding a file does.
|
| |
|
|
|
| |
Allows creating a directory with a specified modtime (in the parent directory entry).
Tests to come shortly.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
We pass a std::auto_ptr<SocketStream> to every Protocol subclass when we
construct it, and it takes control of this object. This reduces the risk of:
* accidentally reusing the same SocketStream for multiple Protocols
(it happened to me in testbackupstore);
* holding onto a reference to the SocketStream;
* allowing a locally-scoped SocketStream to go out of scope and be released
while still being referenced by a live Protocol.
|
| |
|
|
|
|
|
| |
Reading extended attributes may fail with an error if the file was removed
(race condition) or in tests when generating random nonexistent directory
entries. Handle this more gracefully by not backing up the extended attributes
instead of dying completely.
|
| |
|
|
|
|
| |
Rename mrDaemon to mpHousekeeping and make it a pointer, so that it can
officially be NULL, and don't crash if it is, and we fail to get a lock
on the account.
|
| | |
|
| |
|
|
| |
Was introduced by commit bc8261347880b813af58c4b873e1847cca03778d.
|
| | |
|
| |
|
|
| |
Fix previous changes by waiting for forked bbstored process during termination.
|
| | |
|
| | |
|
