From 0540ad493355d0ab5dc56354a43fccd8b6adea5e Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Fri, 20 Sep 2013 15:16:25 +0000 Subject: Add a comment about removing one RaidFileWrite constructor. --- lib/raidfile/RaidFileWrite.h | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'lib/raidfile') diff --git a/lib/raidfile/RaidFileWrite.h b/lib/raidfile/RaidFileWrite.h index bf3c8cc3..e2887167 100644 --- a/lib/raidfile/RaidFileWrite.h +++ b/lib/raidfile/RaidFileWrite.h @@ -27,7 +27,18 @@ class RaidFileDiscSet; class RaidFileWrite : public IOStream { public: + // TODO FIXME we should remove this constructor, and ensure that + // anyone who writes to a RaidFile knows what the reference count + // is before doing so. That requires supporting regenerating the + // reference count database in BackupStoreCheck, and using a real + // database instead of an in-memory array in HousekeepStoreAccount, + // and supporting multiple databases at a time (old and new) in + // BackupStoreRefCountDatabase, and I don't have time to make those + // changes right now. We may even absolutely need to have a full + // reference database, not just reference counts, to implement + // snapshots. RaidFileWrite(int SetNumber, const std::string &Filename); + RaidFileWrite(int SetNumber, const std::string &Filename, int refcount); ~RaidFileWrite(); private: -- cgit v1.2.3