summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikolay Borisov <nborisov@suse.com>2018-06-05 14:39:10 +0300
committerDavid Sterba <dsterba@suse.com>2018-08-06 15:01:32 +0200
commite444c7bfa65fcc71cfe73eda53f27bb8dc41edb2 (patch)
treeced09e75b039953480bac208bc3765b29ab60f2a
parent43ec2761dca211dfd18d5b26afdd7c07036539fe (diff)
btrfs-progs: check: Fix wrong error message in case of corrupted extent
When btrfs check detects a freespace tree extent which ends beyond the blockgroup containing it a misleading error messages is printed. For example if we have the following extent in the freespace tree: item 5 key (30408704 FREE_SPACE_INFO 1073741824) itemoff 16259 itemsize 8 free space info extent count 3 flags 0 item 6 key (30425088 FREE_SPACE_EXTENT 49152) itemoff 16259 itemsize 0 free space extent item 7 key (30507008 FREE_SPACE_EXTENT 65536) itemoff 16259 itemsize 0 free space extent item 8 key (30654464 FREE_SPACE_EXTENT 14524648038063310901) itemoff 16259 itemsize 0 Clearly the last extent is corrupted so we should print something along the lines of: free space extent ends at 14524648038063310901, beyond end of block group 30408704-1104150528 Instead currently this is printed: free space extent ends at 30654464, beyond end of block group 30408704-1104150528 So instead of printing the actual erroneous end, we print the beginning of the extent. Fix this by printing the actual corrupted end. Signed-off-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: Su Yue <suy.fnst@cn.fujitsu.com> Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r--free-space-tree.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/free-space-tree.c b/free-space-tree.c
index 139a031e..b439b6b4 100644
--- a/free-space-tree.c
+++ b/free-space-tree.c
@@ -276,7 +276,7 @@ static int load_free_space_extents(struct btrfs_fs_info *fs_info,
if (key.objectid + key.offset > end) {
fprintf(stderr,
"free space extent ends at %llu, beyond end of block group %llu-%llu\n",
- key.objectid, start, end);
+ key.objectid + key.offset, start, end);
(*errors)++;
break;
}