diff options
author | Anand Jain <anand.jain@oracle.com> | 2014-10-15 08:45:11 +0800 |
---|---|---|
committer | David Sterba <dsterba@suse.cz> | 2014-10-16 12:02:00 +0200 |
commit | 6345bbd5b4f41cd5f4bf090b9f17e6c9c9afcf62 (patch) | |
tree | f0a17b82ac06fe0777c4483effb430166c32c581 | |
parent | d6d44779f5df4ed04a6bdac6330a8e91740a2f7f (diff) |
btrfs-progs: mkfs should be consistent in calling register device
When we have one device we don't call register device.
(in fact not mandatory, but to make it consistent)
And when we have more than one we call register device.
reproducer:
Nothing in the kernel device list
cat /proc/fs/btrfs/devlist | egrep fsid | wc -l
0
mkfs.btrfs will automatically call register device when devices
is more than 1.
mkfs.btrfs -f /dev/sdb /dev/sdc
cat /proc/fs/btrfs/devlist | egrep fsid | wc -l
1
But it does not when there is only one device
mkfs.btrfs -f /dev/sdb
cat /proc/fs/btrfs/devlist | egrep fsid | wc -l
0
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
-rw-r--r-- | mkfs.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -1588,11 +1588,11 @@ int main(int ac, char **av) trans = btrfs_start_transaction(root, 1); + btrfs_register_one_device(file); + if (dev_cnt == 0) goto raid_groups; - btrfs_register_one_device(file); - while (dev_cnt-- > 0) { int old_mixed = mixed; |