|author||Eric Sandeen <email@example.com>||2014-05-13 21:03:04 -0500|
|committer||David Sterba <firstname.lastname@example.org>||2014-08-22 14:39:31 +0200|
btrfs-show-super: don't try to print not-superblocks
If we point btrfs-show-super at a not-btrfs-device and try to print all superblocks, bad things are apt to happen: superblock: bytenr=274877906944, device=/dev/sdc2 --------------------------------------------------------- btrfs-show-super: ctree.h:1984: btrfs_super_csum_size: \ Assertion `!(t >= (sizeof(btrfs_csum_sizes) / sizeof((btrfs_csum_sizes))))' failed. csum 0xAborted Don't try to print superblocks that don't look like superblocks, and add an "-f" (force) option to try anyway, if the user really wants to give it a shot. Fix some spelling & capitalization while we're at it. The manpage says that if any problem happens, 1 will be returned, but that's already not true today LOL, so I didn't bother to make it true when we detect bad sb magic, either... I figure it's worth continuing and trying all superblocks in case just one has a corrupt magic. Signed-off-by: Eric Sandeen <email@example.com> [renamed -f to -F due to clash with existing option, converted relevant docs to asciidoc] Signed-off-by: David Sterba <firstname.lastname@example.org>
Diffstat (limited to 'Documentation')
1 files changed, 4 insertions, 0 deletions
diff --git a/Documentation/btrfs-show-super.txt b/Documentation/btrfs-show-super.txt
index e06157f5..62da6259 100644
@@ -31,6 +31,10 @@ Specify which mirror to print out.
<super_mirror> is between 0 and 2.
If several '-i <super_mirror>' are given, only the last one is valid.
+Attempt to print the superblock even if no superblock magic is found. May end
*btrfs-show-super* will return 0 if no error happened.