diff options
| author | Zach Brown <zab@zabbo.net> | 2014-08-27 11:16:03 -0700 |
|---|---|---|
| committer | David Sterba <dsterba@suse.cz> | 2014-09-14 13:19:44 +0200 |
| commit | 977f2baf363b59d4263d870b292975e2b791cd07 (patch) | |
| tree | 1af5eeb97359b8a0bd6a8d8238ae5e038fba3c19 /cmds-check.c | |
| parent | cf8599c33803932b73e00a54785103030a37a4ee (diff) | |
btrfs-progs: kill BUG_ON in readahead_tree_block()
David sent a quick patch that removed a BUG_ON(). I took a peek and
found that the function was already leaking an eb ref and only returned
0. So this fixes the leak and makes the function void and fixes up the
callers.
Accidentally-motivated-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Zach Brown <zab@zabbo.net>
Signed-off-by: David Sterba <dsterba@suse.cz>
Diffstat (limited to 'cmds-check.c')
| -rw-r--r-- | cmds-check.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/cmds-check.c b/cmds-check.c index 268e588f..d479361a 100644 --- a/cmds-check.c +++ b/cmds-check.c @@ -1287,7 +1287,6 @@ static void reada_walk_down(struct btrfs_root *root, u32 nritems; u32 blocksize; int i; - int ret; int level; level = btrfs_header_level(node); @@ -1299,9 +1298,7 @@ static void reada_walk_down(struct btrfs_root *root, for (i = slot; i < nritems; i++) { bytenr = btrfs_node_blockptr(node, i); ptr_gen = btrfs_node_ptr_generation(node, i); - ret = readahead_tree_block(root, bytenr, blocksize, ptr_gen); - if (ret) - break; + readahead_tree_block(root, bytenr, blocksize, ptr_gen); } } |