diff options
| author | Eric Sandeen <sandeen@redhat.com> | 2013-11-06 17:15:48 -0600 |
|---|---|---|
| committer | Chris Mason <chris.mason@fusionio.com> | 2013-11-07 16:10:41 -0500 |
| commit | 09aa5d3601d0bd9fdb02c3a232daba87e36ca093 (patch) | |
| tree | 8b20c3b627ac807653aa7a8394e1c334e8948e36 /cmds-filesystem.c | |
| parent | 249b93b5efb7bd6625dc1d6831bbb50899ac5da6 (diff) | |
btrfs-progs: btrfs_scan_kernel(): fd==0 is not an error
The error return from open is -1, so test that, not 0,
for success/failure.
Resolves-Coverity-CID: 1125931
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
Diffstat (limited to 'cmds-filesystem.c')
| -rw-r--r-- | cmds-filesystem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cmds-filesystem.c b/cmds-filesystem.c index e920b8a3..376037b5 100644 --- a/cmds-filesystem.c +++ b/cmds-filesystem.c @@ -371,13 +371,13 @@ static int btrfs_scan_kernel(void *search) } fd = open(mnt->mnt_dir, O_RDONLY); - if (fd > 0 && !get_df(fd, &space_info_arg)) { + if ((fd != -1) && !get_df(fd, &space_info_arg)) { get_label_mounted(mnt->mnt_dir, label); print_one_fs(&fs_info_arg, dev_info_arg, space_info_arg, label, mnt->mnt_dir); free(space_info_arg); } - if (fd > 0) + if (fd != -1) close(fd); free(dev_info_arg); } |