diff options
| author | Rosen Penev <rosenp@gmail.com> | 2018-01-07 13:54:21 -0800 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2018-01-31 15:14:03 +0100 |
| commit | e4df433b8a2d5ef944ab4764a5ad237bcdbd1fdc (patch) | |
| tree | 19aa758dee389cea7c86c68ce1c8cc8e9a52836c /cmds-inspect.c | |
| parent | 24103f42ad7a65457a62ae5c0190ea0e428cb14b (diff) | |
btrfs-progs: treewide: Replace strerror(errno) with %m.
As btrfs is specific to Linux, %m can be used instead of strerror(errno)
in format strings. This has some size reduction benefits for embedded
systems.
glibc, musl, and uclibc-ng all support %m as a modifier to printf.
A quick glance at the BIONIC libc source indicates that it has
support for %m as well. BSDs and Windows do not but I do believe
them to be beyond the scope of btrfs-progs.
Compiled sizes on Ubuntu 16.04:
Before:
3916512 btrfs
233688 libbtrfs.so.0.1
4899 bcp
2367672 btrfs-convert
2208488 btrfs-corrupt-block
13302 btrfs-debugfs
2152160 btrfs-debug-tree
2136024 btrfs-find-root
2287592 btrfs-image
2144600 btrfs-map-logical
2130760 btrfs-select-super
2152608 btrfstune
2131760 btrfs-zero-log
2277752 mkfs.btrfs
9166 show-blocks
After:
3908744 btrfs
233256 libbtrfs.so.0.1
4899 bcp
2366560 btrfs-convert
2207432 btrfs-corrupt-block
13302 btrfs-debugfs
2151104 btrfs-debug-tree
2134968 btrfs-find-root
2281864 btrfs-image
2143536 btrfs-map-logical
2129704 btrfs-select-super
2151552 btrfstune
2130696 btrfs-zero-log
2276272 mkfs.btrfs
9166 show-blocks
Total savings: 23928 (24 kilo)bytes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'cmds-inspect.c')
| -rw-r--r-- | cmds-inspect.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/cmds-inspect.c b/cmds-inspect.c index 885f3abe..afd7fe48 100644 --- a/cmds-inspect.c +++ b/cmds-inspect.c @@ -52,7 +52,7 @@ static int __ino_to_path_fd(u64 inum, int fd, int verbose, const char *prepend) ret = ioctl(fd, BTRFS_IOC_INO_PATHS, &ipa); if (ret < 0) { - error("ino paths ioctl: %s", strerror(errno)); + error("ino paths ioctl: %m"); goto out; } @@ -189,7 +189,7 @@ static int cmd_inspect_logical_resolve(int argc, char **argv) ret = ioctl(fd, BTRFS_IOC_LOGICAL_INO, &loi); if (ret < 0) { - error("logical ino ioctl: %s", strerror(errno)); + error("logical ino ioctl: %m"); goto out; } @@ -524,7 +524,7 @@ static int print_min_dev_size(int fd, u64 devid) ret = ioctl(fd, BTRFS_IOC_TREE_SEARCH, &args); if (ret < 0) { - error("tree search ioctl: %s", strerror(errno)); + error("tree search ioctl: %m"); ret = 1; goto out; } |