summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* btrfs-progs: chunk-recover: handle duplicate cache entriesDavid Sterba2016-10-05
| | | | | | Triggered by fuzzed image bko-155621-bad-block-group-offset.raw . Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: print value when assertion failsDavid Sterba2016-10-05
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: image: drop useless bug_onDavid Sterba2016-10-05
| | | | | | | The callers touch 'target', no point checking it inside restore_metadump again. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: image: return negativer error from all paths in mdrestore_initDavid Sterba2016-10-05
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: image: catch zero length extents, avoid endless loopDavid Sterba2016-10-03
| | | | | | | | If an extent is found to have length 0, we'd loop endlessly in copy_from_extent_tree. Reproduced by fuzzed image bko-166361-blocksize-zero.raw within test 002-simple-image . Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: tests: add fuzzed image with bad parent refs, qgroup-verifyDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: check: better error handling in find_parent_rootsDavid Sterba2016-10-03
| | | | | | | | | Fix use-before-sanity-check leading to undefined behaviour and handle errors more gracefully. Reported-by: Lukas Lueg <lukas.lueg@gmail.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=156811 Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: tests: add fuzzed images with bad blocksize/lengh of ebDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: more sanity checks in read_tree_block_fs_infoDavid Sterba2016-10-03
| | | | | | | | | If blocksize is 0, it passes the IS_ALIGNED check but fails later as the length of ebs will be zero. Reported-by: Lukas Lueg <lukas.lueg@gmail.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=169311 Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: btrfstune: use common message helpersDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: image: use common message helpersDavid Sterba2016-10-03
| | | | | | Usage errors are turned to normal errors. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: Remove unnecessary parameter to clear_extent_uptodateQu Wenruo2016-10-03
| | | | | Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com> Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: qgroup: Fix regression leads to corrupted qgroup statusQu Wenruo2016-10-03
| | | | | | | | | | | | | | | | | | | | | | | Commit 93dabf211d74daf6e3de642bdd887a90a00f7b49 Author: Mark Fasheh <mfasheh@suse.de> Date: Fri Jun 17 13:37:48 2016 -0700 btrfs-progs: check: verify qgroups above level 0 This commit introduced a new regression which corrupts read_qgroup_status, since it iterate leaf with manually specified slot, not correct path->slot[0]. This leads to wrong slot[0] and read_qgroup_status() will read out wrong flags, leading to regression. Fix read_qgroup_status() by using eb and slot instread of wrong path strucutre. Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com> Cc: Mark Fasheh <mfasheh@suse.de> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com> Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: constify string arguments where appropriateDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: don't write to optarg in btrfs_qgroup_parse_sort_stringDavid Sterba2016-10-03
| | | | | | | Dup the string that gets passed to strtok so we don't destroy callers buffer. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: remove stray function declarationDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: restore: update help textDavid Sterba2016-10-03
| | | | | | | Make it clear that --xattr restores the xattrs. Fix some whitespace damage and add an enum for the long-only option. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: super-recover: Reuse btrfs_read_dev_super functionQu Wenruo2016-10-03
| | | | | | | | | | | | We have enhanced super block validation check in disk_io.c, while super-recover doesn't use that function and use a custom one. That is duplicated, so reuse btrfs_read_dev_super to handle it, which not only enhanced super check, but also reduce the code length. Reported-by: hawken <hawken@thehawken.org> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com> Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: Return more meaningful value for btrfs_read_deve_superQu Wenruo2016-10-03
| | | | | | | | | | | | | | btrfs_read_dev_super() only returns 0 or -1, which doesn't really help, caller won't know if it's caused by bad superblock or superblock out of range. Return -errno if pread64() return -1, and return -EOF if none or part of the super is read out, and return what check_super() returned. So caller can get -EIO to catch real corrupted super blocks. Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com> Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: fix user-facing typos in docs and help stringsNicholas D Steeves2016-10-03
| | | | | Signed-off-by: Nicholas D Steeves <nsteeves@gmail.com> Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: docs: document exit codes from scrubAdam Borowski2016-10-03
| | | | | Signed-off-by: Adam Borowski <kilobyte@angband.pl> Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: move 3rd party kernel library modules to own directoryDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: build: add basic support for subdirectory buildDavid Sterba2016-10-03
| | | | | | Add explicit target file names and set the top source directory. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: tests: add script to scan results for some known runtime errorsDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: tests: iterate over fuzzed images and test various toolsDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: change btrfs_csum_final result param type to u8Domagoj Tršan2016-10-03
| | | | | Signed-off-by: Domagoj Tršan <domagoj.trsan@gmail.com> Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: convert: check source file system stateLakshmipathi.G2016-10-03
| | | | | | Signed-off-by: Lakshmipathi.G <Lakshmipathi.G@giis.co.in> [ add doc note ] Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: mkfs: remove useless helperDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: use PATH_MAX in cmd_inspect_logical_resolveDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: remove unused variable in add_inode_itemsDavid Sterba2016-10-03
| | | | | | It hasn't been used since the first commit. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: cleanup, kill trivial btrfs_key_type helperDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: cleanup, kill trivial btrfs_set_key_type helperDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: improve error handling in clone_inode_recDavid Sterba2016-10-03
| | | | | | Cleanup the rb_tree. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: corrupt-block: fix assertion conditionDavid Sterba2016-10-03
| | | | | | | The ->data is no longer a pointer but an embedded array. Resolves-coverity-id: 1372671 Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: check: switch some messages to common helpersDavid Sterba2016-10-03
| | | | | | | Switch the messages that do not come from the actual image checking, more like the parameter verification. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: image: switch to common message helpersDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: convert: improve error handling in do_rollbackDavid Sterba2016-10-03
| | | | | | Handle transaction errors. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: check: improve error handling in add_extent_rec_nolookupDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: check: handle errors returned by add_extent_rec_nolookupDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: use standard allocation functions in non-kenrel codeDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: improve error handling in btrfs_add_to_fsidDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: corrupt-block: improved error handling in corrupt_item_nocowDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: dump-super: switch to common message helpersDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: improve error handling in btrfs_alloc_data_chunkDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: remove redundant check in btrfs_add_to_fsidDavid Sterba2016-10-03
| | | | | | The callers do the sanity checks. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: prop: simplify help printing codeDavid Sterba2016-10-03
| | | | | | Remove a trivial helper. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: tree-stats: switch to common message helpersDavid Sterba2016-10-03
| | | | Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: fi du: improved error handling in mark_inode_seenDavid Sterba2016-10-03
| | | | | | The callchain handles errors, don't crash on unexpected condition. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: fi du: catch bogus extent lengthsDavid Sterba2016-10-03
| | | | | | | If we get a zero-length from the ioctl for whatever reason, we should not crash. Signed-off-by: David Sterba <dsterba@suse.com>
* btrfs-progs: inspect: improved error handlingDavid Sterba2016-09-21
| | | | | | Two remaining BUG_ON, be more specific what's wrong. Signed-off-by: David Sterba <dsterba@suse.com>