From 7c9f323a7c9c7a0d7b516ed9974308bde4017ae2 Mon Sep 17 00:00:00 2001 From: Zach Brown Date: Tue, 22 Jan 2013 13:48:04 -0800 Subject: btrfs-progs: check for open failure, don't close Check for failure by testing for a negative file descriptor, not a descriptor of 0. And if it failed we have nothing to close(). Signed-off-by: Zach Brown --- cmds-device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmds-device.c b/cmds-device.c index d4938f4e..7a0f7a40 100644 --- a/cmds-device.c +++ b/cmds-device.c @@ -87,9 +87,8 @@ static int cmd_add_dev(int argc, char **argv) } devfd = open(argv[i], O_RDWR); - if (!devfd) { + if (devfd < 0) { fprintf(stderr, "ERROR: Unable to open device '%s'\n", argv[i]); - close(devfd); ret++; continue; } -- cgit v1.2.3