From 7e47c6d32933cc68aadb9a00072fe24500c6d5e5 Mon Sep 17 00:00:00 2001 From: Qu Wenruo Date: Mon, 28 Apr 2014 16:37:30 +0800 Subject: btrfs-progs: Replace the overkill assert with normal error message. When 'btrfs replace status' encounters an unknown dev replace status, it will cause an assert, which is somewhat overkilled and can be replaced with a normal error message. Signed-off-by: Qu Wenruo Signed-off-by: David Sterba --- cmds-replace.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'cmds-replace.c') diff --git a/cmds-replace.c b/cmds-replace.c index 645dc988..9eb981ba 100644 --- a/cmds-replace.c +++ b/cmds-replace.c @@ -449,7 +449,10 @@ static int print_replace_status(int fd, const char *path, int once) break; default: prevent_loop = 1; - assert(0); + fprintf(stderr, + "Unknown btrfs dev replace status:%llu", + status->replace_state); + ret = -EINVAL; break; } @@ -459,9 +462,9 @@ static int print_replace_status(int fd, const char *path, int once) (unsigned long long)status->num_write_errors, (unsigned long long) status->num_uncorrectable_read_errors); - if (once || prevent_loop) { + if (once || prevent_loop || ret) { printf("\n"); - return 0; + return ret; } fflush(stdout); -- cgit v1.2.3