From b2e99e1819d967828edf149db5a203e59a40e379 Mon Sep 17 00:00:00 2001 From: Eryu Guan Date: Fri, 10 Jan 2014 22:50:02 +0800 Subject: Btrfs-progs: check return value of read_tree_block() in check_chunks_and_extents() The following steps could trigger btrfs segfault: mkfs -t btrfs -m raid5 -d raid5 /dev/loop{0..3} losetup -d /dev/loop2 btrfs check /dev/loop0 The reason is that read_tree_block() returns NULL and add_root_to_pending() dereferences it without checking it first. Also replace a BUG_ON with proper error checking. Signed-off-by: Eryu Guan Signed-off-by: David Sterba Signed-off-by: Chris Mason --- free-space-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'free-space-cache.c') diff --git a/free-space-cache.c b/free-space-cache.c index 1ca7980d..55d73185 100644 --- a/free-space-cache.c +++ b/free-space-cache.c @@ -435,7 +435,7 @@ int load_free_space_cache(struct btrfs_fs_info *fs_info, if (ret < 0) { ret = 0; - printf("failed to load free space cache for block group %llu", + printf("failed to load free space cache for block group %llu\n", block_group->key.objectid); } -- cgit v1.2.1