diff options
| author | Neil Okamoto <neil.okamoto@gmail.com> | 2018-02-06 08:51:04 -0800 |
|---|---|---|
| committer | Bozhidar Batsov <bozhidar.batsov@gmail.com> | 2018-03-05 08:13:41 +0700 |
| commit | 30fe9ea32446bb90057d3c57334a9cbe868e8e69 (patch) | |
| tree | c458f7fc2457d8f4ef2fd4fa18a74edf6acbf2d8 /.github | |
| parent | f65d3246662874b6f8d71d1e64257dcf635b4fc9 (diff) | |
[Fix #2199] Implement elisp-lint.el in CI
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 69e1ea1e..d0a5e169 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,9 +9,8 @@ by checking the relevant checkboxes): - [ ] The commits are consistent with our [contribution guidelines][1] - [ ] You've added tests (if possible) to cover your change(s) - [ ] All tests are passing (`make test`) -- [ ] The new code is does not generate warnings from: - - [byte-compilation](https://www.gnu.org/software/emacs/manual/html_node/elisp/Byte-Compilation.html) (`make test-bytecomp`) - - [`checkdoc`](https://www.gnu.org/software/emacs/manual/html_node/elisp/Tips.html) (`make test-checks`) +- [ ] All code passes the linter (`make lint`) which is based on [`elisp-lint`](https://github.com/gonewest818/elisp-lint) and includes + - [byte-compilation](https://www.gnu.org/software/emacs/manual/html_node/elisp/Byte-Compilation.html), [`checkdoc`](https://www.gnu.org/software/emacs/manual/html_node/elisp/Tips.html), [check-declare](https://www.gnu.org/software/emacs/manual/html_node/elisp/Declaring-Functions.html), packaging metadata, indentation, and trailing whitespace checks. - [ ] You've updated the [changelog][3] (if adding/changing user-visible functionality) - [ ] You've updated the [user manual][4] (if adding/changing user-visible functionality) |