summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVitalie Spinu <spinuvit@gmail.com>2018-11-09 17:29:32 +0100
committerBozhidar Batsov <bozhidar.batsov@gmail.com>2018-11-10 15:13:56 +0100
commit3a520ec76cdd5509bf231e49809715f20a87d74b (patch)
treec010e61c98ba6f3fd03ead7a5a8daab9c260b3dd
parent906295826d0619146d41e1582b9b3f0b96d3b68c (diff)
[Fix #2514] Don't auto-jump to warnings even when they are under stderr face
-rw-r--r--CHANGELOG.md13
-rw-r--r--cider-eval.el3
2 files changed, 9 insertions, 7 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 184ea5af..50049f58 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,13 +10,14 @@
### Bug fixes
-* [#2453](https://github.com/clojure-emacs/cider/issues/2453) Make it possible to debug deftype methods by direct insertion of #dbg and #break readers into the deftype methods.
+* [#2514](https://github.com/clojure-emacs/cider/issues/2514): Don't auto-jump to warnings when `cider-auto-jump-to-error` is set to 'errors-only.
+* [#2453](https://github.com/clojure-emacs/cider/issues/2453): Make it possible to debug deftype methods by direct insertion of #dbg and #break readers into the deftype methods.
* [#1869](https://github.com/clojure-emacs/cider/issues/1869),[cider-nrepl#460](https://github.com/clojure-emacs/cider-nrepl/issues/460): Fix `continue` debugger command which was stopping entering debugger on repeated invocations.
-* [#2444](https://github.com/clojure-emacs/cider/issues/2444) Reuse dead REPL buffers on new connections.
-* [#2441](https://github.com/clojure-emacs/cider/issues/2441) Make it possible to use `C-c C-x` keys without loading cider first (autoload `cider-start-map`).
-* [#2440](https://github.com/clojure-emacs/cider/issues/2440) Make `cider-check-cljs-repl-requirements` take effect again.
-* [#2439](https://github.com/clojure-emacs/cider/issues/2439) Remove mentions of `cider-toggle-connection-buffer` from the docs.
-* [#2435](https://github.com/clojure-emacs/cider/issues/2435) Remove killed REPLs from sessions in client sentinel.
+* [#2444](https://github.com/clojure-emacs/cider/issues/2444): Reuse dead REPL buffers on new connections.
+* [#2441](https://github.com/clojure-emacs/cider/issues/2441): Make it possible to use `C-c C-x` keys without loading cider first (autoload `cider-start-map`).
+* [#2440](https://github.com/clojure-emacs/cider/issues/2440): Make `cider-check-cljs-repl-requirements` take effect again.
+* [#2439](https://github.com/clojure-emacs/cider/issues/2439): Remove mentions of `cider-toggle-connection-buffer` from the docs.
+* [#2435](https://github.com/clojure-emacs/cider/issues/2435): Remove killed REPLs from sessions in client sentinel.
* Fix jack-in from inside of remote buffers.
* [#2454](https://github.com/clojure-emacs/cider/pull/2454): Fix erratic inspector behavior when multiple REPLs are connected
* [#2467](https://github.com/clojure-emacs/cider/pull/2467): Make generic CIDER ops use any available nREPL connection.
diff --git a/cider-eval.el b/cider-eval.el
index 67f2706b..643fc93a 100644
--- a/cider-eval.el
+++ b/cider-eval.el
@@ -377,7 +377,8 @@ evaluation command. Honor `cider-auto-jump-to-error'."
(let* ((face (nth 3 info))
(note (nth 4 info))
(auto-jump (if (eq cider-auto-jump-to-error 'errors-only)
- (not (eq face 'cider-warning-highlight-face))
+ (not (or (eq face 'cider-warning-highlight-face)
+ (string-match-p "warning" note)))
cider-auto-jump-to-error)))
(overlay-put overlay 'cider-note-p t)
(overlay-put overlay 'font-lock-face face)