summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CHANGELOG.md1
-rw-r--r--cider-test.el18
2 files changed, 11 insertions, 8 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index b9576f0b..fe39d726 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -35,6 +35,7 @@
### Bugs fixed
* [cider-nrepl#329](https://github.com/clojure-emacs/cider-nrepl/pull/329): Fix error instrumenting functions that call clojure.tools.logging.
+* [#1643](https://github.cim/clojure-emacs/cider/issues/1643): Running tests no longer deletes unrelated overlays.
* [#1632](https://github.com/clojure-emacs/cider/pull/1632): Redefining a function correctly updates eldoc.
* [#1630](https://github.com/clojure-emacs/cider/pull/1630): The debugger no longer gets confused inside `@` redefs.
* [#1599](https://github.com/clojure-emacs/cider/pull/1599): Don't error when test makes 0 assertions.
diff --git a/cider-test.el b/cider-test.el
index 1f1fb9b4..e4f6383c 100644
--- a/cider-test.el
+++ b/cider-test.el
@@ -33,6 +33,7 @@
(require 'cider-popup)
(require 'cider-stacktrace)
(require 'cider-compat)
+(require 'cider-overlays)
(require 'button)
(require 'easymenu)
@@ -468,13 +469,13 @@ The optional arg TEST denotes an individual test name."
(search-forward "(" nil t)
(let ((beg (point)))
(forward-sexp)
- (let ((overlay (make-overlay beg (point))))
- (overlay-put overlay 'font-lock-face (cider-test-type-face type))
- (overlay-put overlay 'type type)
- (overlay-put overlay 'help-echo message)
- (overlay-put overlay 'message message)
- (overlay-put overlay 'expected expected)
- (overlay-put overlay 'actual actual))))))))
+ (cider--make-overlay beg (point) 'cider-test
+ 'font-lock-face (cider-test-type-face type)
+ 'type type
+ 'help-echo message
+ 'message message
+ 'expected expected
+ 'actual actual)))))))
(defun cider-find-var-file (ns var)
"Return the buffer visiting the file in which the NS VAR is defined.
@@ -507,7 +508,8 @@ Or nil if not found."
(dolist (var (nrepl-dict-keys vars))
(when-let ((buffer (cider-find-var-file ns var)))
(with-current-buffer buffer
- (remove-overlays)))))
+ (remove-overlays (point-min) (point-max)
+ 'cider-type 'cider-test)))))
cider-test-last-results)))