diff options
| author | Michael R Sweet <michael.r.sweet@gmail.com> | 2020-10-17 22:55:54 -0400 |
|---|---|---|
| committer | Michael R Sweet <michael.r.sweet@gmail.com> | 2020-10-17 22:55:54 -0400 |
| commit | fbcea2903fa618036823ad044aa541d0abfe242b (patch) | |
| tree | e11a06f09c2a011ac2efe7e1455c08c29ace286b /scheduler/ipp.c | |
| parent | 8b5777b6f62d91a21f31c7458a64ad51b0c06aba (diff) | |
Eliminate a bunch of sprintf usage (all looked safe, but I'm puzzled why these
were still there - I did a sweep many years ago...)
Diffstat (limited to 'scheduler/ipp.c')
| -rw-r--r-- | scheduler/ipp.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/scheduler/ipp.c b/scheduler/ipp.c index 2fe3bf25c..0c44d7d4a 100644 --- a/scheduler/ipp.c +++ b/scheduler/ipp.c @@ -10866,17 +10866,13 @@ set_printer_defaults( case IPP_TAG_INTEGER : case IPP_TAG_ENUM : - sprintf(value, "%d", attr->values[0].integer); - printer->num_options = cupsAddOption(name, value, - printer->num_options, - &(printer->options)); + printer->num_options = cupsAddIntegerOption(name, attr->values[0].integer, printer->num_options, &(printer->options)); cupsdLogMessage(CUPSD_LOG_DEBUG, "Setting %s to %s...", attr->name, value); break; case IPP_TAG_RANGE : - sprintf(value, "%d-%d", attr->values[0].range.lower, - attr->values[0].range.upper); + snprintf(value, sizeof(value), "%d-%d", attr->values[0].range.lower, attr->values[0].range.upper); printer->num_options = cupsAddOption(name, value, printer->num_options, &(printer->options)); @@ -10885,10 +10881,7 @@ set_printer_defaults( break; case IPP_TAG_RESOLUTION : - sprintf(value, "%dx%d%s", attr->values[0].resolution.xres, - attr->values[0].resolution.yres, - attr->values[0].resolution.units == IPP_RES_PER_INCH ? - "dpi" : "dpcm"); + snprintf(value, sizeof(value), "%dx%d%s", attr->values[0].resolution.xres, attr->values[0].resolution.yres, attr->values[0].resolution.units == IPP_RES_PER_INCH ? "dpi" : "dpcm"); printer->num_options = cupsAddOption(name, value, printer->num_options, &(printer->options)); |