summaryrefslogtreecommitdiff
path: root/Debian/Debhelper/Buildsystem/cmake.pm
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-04-10 17:05:23 -0400
committerJoey Hess <joey@gnu.kitenet.net>2009-04-10 17:05:23 -0400
commit2b7f42f9ef70c08bb7bc138fb8b24dc993da54ac (patch)
treeb215c75636fc08ed9e2571effdbd8854e441fcd4 /Debian/Debhelper/Buildsystem/cmake.pm
parent776abbb23a899ebba954774c8b3740706a21f72b (diff)
code review, added comments
I went through every line of the buildsystem implementation, and added numerous comments. Search for "XXX JEH" to find them.
Diffstat (limited to 'Debian/Debhelper/Buildsystem/cmake.pm')
-rw-r--r--Debian/Debhelper/Buildsystem/cmake.pm5
1 files changed, 5 insertions, 0 deletions
diff --git a/Debian/Debhelper/Buildsystem/cmake.pm b/Debian/Debhelper/Buildsystem/cmake.pm
index d7504d1..00f6be4 100644
--- a/Debian/Debhelper/Buildsystem/cmake.pm
+++ b/Debian/Debhelper/Buildsystem/cmake.pm
@@ -42,7 +42,12 @@ sub configure_impl {
$self->_add_cmake_flag("CMAKE_SKIP_RPATH", "ON");
$self->_add_cmake_flag("CMAKE_VERBOSE_MAKEFILE", "ON");
# TODO: LDFLAGS
+ # XXX JEH why are we using a method and an object
+ # field to build up a simple one-time-use list?
+ # my @flags;
+ # push @flags, ... if $foo
+ # XXX JEH again a non-sequitor get_topdir.
doit("cmake", $self->get_topdir(), @{$self->{cmake_flags}}, @_);
}