summaryrefslogtreecommitdiff
path: root/dh
diff options
context:
space:
mode:
authorRoger Leigh <rleigh@debian.org>2010-11-22 21:03:24 +0000
committerJoey Hess <joey@kitenet.net>2010-11-22 17:52:50 -0400
commitef182486a7deeaf60449ddbf2f37b4666a7b642a (patch)
tree1890d3c6f9585cb7adbcf2b541e4958c77c3f39d /dh
parent2db72cd19a20bf1685c17d2a437e60ba097f0d8b (diff)
dh: Use $(filter) rather than $(findstring)
$(findstring) can match partial strings and so is unreliable when a package builds several binary packages and one package contains the name of another package within its name. In these cases, $(findstring) can return a partial match which leads to problems (performing unwanted actions which could lead to build failure, for example). $(filter) matches the entire string in the wordlist, so is a reliable replacement for $(findstring). Signed-off-by: Roger Leigh <rleigh@debian.org>
Diffstat (limited to 'dh')
-rwxr-xr-xdh2
1 files changed, 1 insertions, 1 deletions
diff --git a/dh b/dh
index d2771ab..21863dd 100755
--- a/dh
+++ b/dh
@@ -233,7 +233,7 @@ L<dh_listpackages(1)> to test what is being built. For example:
override_dh_fixperms:
dh_fixperms
- ifneq (,$(findstring foo, $(shell dh_listpackages)))
+ ifneq (,$(filter foo, $(shell dh_listpackages)))
chmod 4755 debian/foo/usr/bin/foo
endif