diff options
author | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2018-10-02 13:31:16 +0100 |
---|---|---|
committer | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2018-10-02 13:40:17 +0100 |
commit | 9e243b135e3ba9df16299a664c0fc3ff7e138349 (patch) | |
tree | 50829f4a2811dea45cc51673ab4060ff36f85c46 | |
parent | b6e890bca43290a8fd54cb7dcc1958dab7f17f4e (diff) |
Dgit.pm: reflog_cache_lookup: Replace `confess' with `die' after exec
With `confess' after `exec', perl complains
Statement unlikely to be reached at /usr/share/perl5/Debian/Dgit.pm line 770.
(Maybe you meant system() when you said exec()?)
The error message's suggestion is not right here - what is wrong is
that confess is not really appropriate in the child in this way.
Replace it with die, using a better error string.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
-rw-r--r-- | Debian/Dgit.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Debian/Dgit.pm b/Debian/Dgit.pm index 004daeb..39c4598 100644 --- a/Debian/Dgit.pm +++ b/Debian/Dgit.pm @@ -767,7 +767,7 @@ sub reflog_cache_lookup ($$) { printdebug ">(no reflog)\n"; finish 0; } - exec @cmd; confess $!; + exec @cmd; die f_ "exec %s: %s\n", $cmd[0], $!; } while (<GC>) { chomp; |