diff options
author | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2019-08-08 12:30:46 +0100 |
---|---|---|
committer | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2019-08-11 00:09:28 +0100 |
commit | bbc8063258e22fb5270d27f3d5c74215c88a8785 (patch) | |
tree | e156041745f4dd015689a5685dcef351b583e589 | |
parent | 9ff427424a06206e33200773b317f6e70ac0e2f7 (diff) |
dgit: WWW::Curl Set $response_body to '' explicitly
check_for_git calls url_fetch with a WWW::Curl parameter
CURLOPT_NOBODY which suppresses saving the body. The result is that
CURLOPT_WRITEDATA does not update $response_body. Then, even on
success, url_fetch returns undef (which ought to mean 404).
Strictly this is a bit sneaky of check_for_git. But, rather than
trying to make this interface more formal, just make url_fetch set
$response_body to ''. It does return this except in the success case,
so the error cases are still handled right.
Closes: #934126
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
-rwxr-xr-x | dgit | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1191,7 +1191,7 @@ sub url_fetch ($;@) { confess "$k $v ".$curl->strerror($x)." ?" if $x; }; - my $response_body; + my $response_body = ''; $setopt->(CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTPS|CURLPROTO_HTTP); $setopt->(CURLOPT_URL, $url); $setopt->(CURLOPT_NOSIGNAL, 1); |