summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Jackson <ijackson@chiark.greenend.org.uk>2015-11-16 23:05:55 +0000
committerIan Jackson <ijackson@chiark.greenend.org.uk>2016-07-16 16:47:47 +0100
commite17b7eb17ed4aa309c1a1b3757db1e0fc123df68 (patch)
tree675d4f0ea892d9413907502fc61abd9aa1e69f7c
parentea2e4102e8f2f461443978240a18cc3ea011b9bd (diff)
Split brain: Move $oldtiptree calculation out of quiltify (nfc)
And pass the result as an argument. Code outside quiltify is going to want this information.
-rwxr-xr-xdgit18
1 files changed, 9 insertions, 9 deletions
diff --git a/dgit b/dgit
index 4d7c721..2c72213 100755
--- a/dgit
+++ b/dgit
@@ -2540,8 +2540,8 @@ sub quilt_could_gbp ($$$) {
quiltify_trees_differ($userhead,$applied,1);
}
-sub quiltify ($$$) {
- my ($clogp,$target,$unapplied) = @_;
+sub quiltify ($$$$) {
+ my ($clogp,$target,$unapplied,$oldtiptree) = @_;
# Quilt patchification algorithm
#
@@ -2567,12 +2567,6 @@ sub quiltify ($$$) {
# After traversing PT, we git commit the changes which
# should be contained within debian/patches.
- changedir '../fake';
- rmtree '.pc';
- runcmd @git, qw(add -Af .);
- my $oldtiptree=git_write_tree();
- changedir '../work';
-
# The search for the path S..T is breadth-first. We maintain a
# todo list containing search nodes. A search node identifies a
# commit, and looks something like this:
@@ -2994,7 +2988,13 @@ END
rename '../fake/.pc','.pc' or die $!;
}
- quiltify($clogp,$headref,$unapplied);
+ changedir '../fake';
+ rmtree '.pc';
+ runcmd @git, qw(add -Af .);
+ my $oldtiptree=git_write_tree();
+ changedir '../work';
+
+ quiltify($clogp,$headref,$unapplied,$oldtiptree);
if (!open P, '>>', ".pc/applied-patches") {
$!==&ENOENT or die $!;