diff options
author | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2016-10-24 01:01:58 +0100 |
---|---|---|
committer | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2016-10-24 01:43:50 +0100 |
commit | dc204aadf2b4afa84fd002597041fc9e5b981d83 (patch) | |
tree | de982b3fbc64e0f39a4e09a51e5b26db9786c416 /Debian | |
parent | 37913654d58e03354aa4d5a6aa5afb9c5aeca6b7 (diff) |
Dgit.pm: Break out failedcmd_waitstatus
No functional change.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Diffstat (limited to 'Debian')
-rw-r--r-- | Debian/Dgit.pm | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/Debian/Dgit.pm b/Debian/Dgit.pm index 6854a7c..57ae994 100644 --- a/Debian/Dgit.pm +++ b/Debian/Dgit.pm @@ -41,7 +41,8 @@ BEGIN { stat_exists link_ltarget hashfile fail ensuredir executable_on_path - waitstatusmsg failedcmd_report_cmd failedcmd + waitstatusmsg failedcmd_waitstatus + failedcmd_report_cmd failedcmd cmdoutput cmdoutput_errok git_rev_parse git_get_ref git_for_each_ref git_for_each_tag_referring is_fast_fwd @@ -223,6 +224,16 @@ sub failedcmd_report_cmd { { local ($!); printcmd \*STDERR, _us().": $intro:", @_ or die $!; }; } +sub failedcmd_waitstatus { + if ($? < 0) { + return "failed to fork/exec: $!"; + } elsif ($?) { + return "subprocess ".waitstatusmsg(); + } else { + return "subprocess produced invalid output"; + } +} + sub failedcmd { # Expects $!,$? as set by close - see below. # To use with system(), set $?=-1 first. @@ -236,13 +247,7 @@ sub failedcmd { # program failed trashed $? >0 system # syscall failure $! >0 unchanged system failedcmd_report_cmd undef, @_; - if ($? < 0) { - fail "failed to fork/exec: $!"; - } elsif ($?) { - fail "subprocess ".waitstatusmsg(); - } else { - fail "subprocess produced invalid output"; - } + fail failedcmd_waitstatus(); } sub cmdoutput_errok { |