diff options
author | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2020-06-22 16:09:15 +0100 |
---|---|---|
committer | Ian Jackson <ijackson@chiark.greenend.org.uk> | 2020-06-22 16:35:38 +0100 |
commit | cf46ae056b60535bb6668faa9d0bd7ea1d33dba1 (patch) | |
tree | 5461b883a7aa840c06b2e8e80fcc2a2e262ecb96 /git-debpush.1.pod | |
parent | 357fe8157dd06aad0e998a37f6cdb3c582ee5be0 (diff) |
Fix upstream_commitish_search API
upstream_commitish_search used to return a commit. If it succeeded
The caller could find the tag in $tried[-1]. Both callers relied on
this unpleasant and error-prone API.
In
0bb8e2a87e3c8b5be0fce5c2491b292e9273056e
Dgit::upstream_commitish_search: fail if more than one tag exists
the algorithm was changed to keep looking, so it can reject ambiguous
situations. The result is that $tried[-1] is entirely wrong in the
success case. (This is spotted by the tagupl-baredebian test.)
It would have been possible to fix this by making
upstream_commitish_search synthesise a suitable return value for
putting in $tried, but that is absurd.
Instead give this function a sensible calling convention. It now
returns a list of the tag name (for messages etc.) and the
commitish (for use). Change both call sites.
CC: Sean Whitton <spwhitton@spwhitton.name>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Diffstat (limited to 'git-debpush.1.pod')
0 files changed, 0 insertions, 0 deletions