summaryrefslogtreecommitdiff
path: root/git-debrebase
diff options
context:
space:
mode:
authorIan Jackson <ijackson@chiark.greenend.org.uk>2018-08-11 11:43:40 +0100
committerIan Jackson <ijackson@chiark.greenend.org.uk>2018-08-11 11:43:40 +0100
commite8ab02477159b5bd91a3566dc28367ed4a910b3a (patch)
tree6fcce5bf71850aa27297421a108a71073f3d1a34 /git-debrebase
parent892352e386b2908574d660df3ee778171f59995b (diff)
git-debrebase: merge: Comment about laundry of merge of unstitched
I have concluded that this is not a problem avoidable by git-debrebase, and that any trouble will be tolerable (at least, not data loss). The user should try to avoid doing this. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Diffstat (limited to 'git-debrebase')
-rwxr-xr-xgit-debrebase12
1 files changed, 10 insertions, 2 deletions
diff --git a/git-debrebase b/git-debrebase
index c463f4a..2b257dd 100755
--- a/git-debrebase
+++ b/git-debrebase
@@ -1082,8 +1082,16 @@ sub walk ($;$$$) {
}
die "$ty ?";
} elsif ($ty eq 'VanillaMerge' or $ty eq 'MergedBreakwaters') {
- # xxx need to handle ffq if one side was unstitched
- # wait both of them may be!
+ # User may have merged unstitched branch(es). We will
+ # have now lost what ffq-prev was then (since the later
+ # pseudomerge may introduce further changes). The effect
+ # of resolving such a merge is that we may have to go back
+ # further in history to find a merge base, since the one
+ # which was reachable via ffq-prev is no longer findable.
+ # This is suboptimal, but if it all works we'll have done
+ # the right thing.
+ # xxx we should warn the user in the docs about this
+
my $ok=1;
my $best_anchor;
# We expect to find a dominating anchor amongst the