From 791b5fe6f1ae18b11277f8bb5bc83d8029c57503 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed, 21 Dec 2016 21:46:22 +0000
Subject: option parsing: Rework --dep14tag options, introducing `defoptmodes'

No functional change.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---
 dgit | 47 ++++++++++++++++++++++++++++++++---------------
 1 file changed, 32 insertions(+), 15 deletions(-)

diff --git a/dgit b/dgit
index afdf2c5..1974581 100755
--- a/dgit
+++ b/dgit
@@ -70,7 +70,6 @@ our $overwrite_version; # undef: not specified; '': check changelog
 our $quilt_mode;
 our $quilt_modes_re = 'linear|smash|auto|nofix|nocheck|gbp|dpm|unapplied';
 our $dodep14tag;
-our $dodep14tag_re = 'want|no|always';
 our $split_brain_save;
 our $we_are_responder;
 our $we_are_initiator;
@@ -6257,7 +6256,9 @@ sub cmd_version {
 }
 
 our (%valopts_long, %valopts_short);
+our (%funcopts_long);
 our @rvalopts;
+our (@modeopt_cfgs);
 
 sub defvalopt ($$$$) {
     my ($long,$short,$val_re,$how) = @_;
@@ -6293,6 +6294,26 @@ defvalopt '--initiator-tempdir','','.*', sub {
 	" absolute, not relative, directory."
 };
 
+sub defoptmodes ($@) {
+    my ($varref, $cfgkey, $default, %optmap) = @_;
+    my %permit;
+    while (my ($opt,$val) = each %optmap) {
+	$funcopts_long{$opt} = sub { $$varref = $val; };
+	$permit{$val} = $val;
+    }
+    push @modeopt_cfgs, {
+        Var => $varref,
+        Key => $cfgkey,
+        Default => $default,
+        Vals => \%permit
+    };
+}
+
+defoptmodes \$dodep14tag, qw( dep14tag          want
+			      --dep14tag        want
+			      --no-dep14tag     no
+			      --always-dep14tag always );
+
 sub parseopts () {
     my $om;
 
@@ -6375,15 +6396,6 @@ sub parseopts () {
 	    } elsif (m/^--overwrite=(.+)$/s) {
 		push @ropts, $_;
 		$overwrite_version = $1;
-	    } elsif (m/^--dep14tag$/s) {
-		push @ropts, $_;
-		$dodep14tag= 'want';
-	    } elsif (m/^--no-dep14tag$/s) {
-		push @ropts, $_;
-		$dodep14tag= 'no';
-	    } elsif (m/^--always-dep14tag$/s) {
-		push @ropts, $_;
-		$dodep14tag= 'always';
 	    } elsif (m/^--delayed=(\d+)$/s) {
 		push @ropts, $_;
 		push @dput, $_;
@@ -6422,6 +6434,9 @@ sub parseopts () {
 	    } elsif (m/^(--[-0-9a-z]+)(=|$)/ && ($oi = $valopts_long{$1})) {
 		$val = $2 ? $' : undef; #';
 		$valopt->($oi->{Long});
+	    } elsif ($funcopts_long{$_}) {
+		push @ropts, $_;
+		$funcopts_long{$_}();
 	    } else {
 		badusage "unknown long option \`$_'";
 	    }
@@ -6554,12 +6569,14 @@ sub parseopts_late_defaults () {
 	$quilt_mode = $1;
     }
 
-    if (!defined $dodep14tag) {
+    foreach my $moc (@modeopt_cfgs) {
 	local $access_forpush;
-	$dodep14tag = access_cfg('dep14tag', 'RETURN-UNDEF') // 'want';
-	$dodep14tag =~ m/^($dodep14tag_re)$/ 
-	    or badcfg "unknown dep14tag setting \`$dodep14tag'";
-	$dodep14tag = $1;
+	my $vr = $moc->{Var};
+	next if defined $$vr;
+	$$vr = access_cfg($moc->{Key}, 'RETURN-UNDEF') // $moc->{Default};
+	my $v = $moc->{Vals}{$$vr};
+	badcfg "unknown $moc->{Key} setting \`$$vr'" unless defined $v;
+	$$vr = $v;
     }
 
     $need_split_build_invocation ||= quiltmode_splitbrain();
-- 
cgit v1.2.3