From 9e243b135e3ba9df16299a664c0fc3ff7e138349 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 2 Oct 2018 13:31:16 +0100 Subject: Dgit.pm: reflog_cache_lookup: Replace `confess' with `die' after exec With `confess' after `exec', perl complains Statement unlikely to be reached at /usr/share/perl5/Debian/Dgit.pm line 770. (Maybe you meant system() when you said exec()?) The error message's suggestion is not right here - what is wrong is that confess is not really appropriate in the child in this way. Replace it with die, using a better error string. Signed-off-by: Ian Jackson --- Debian/Dgit.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Debian') diff --git a/Debian/Dgit.pm b/Debian/Dgit.pm index 004daeb..39c4598 100644 --- a/Debian/Dgit.pm +++ b/Debian/Dgit.pm @@ -767,7 +767,7 @@ sub reflog_cache_lookup ($$) { printdebug ">(no reflog)\n"; finish 0; } - exec @cmd; confess $!; + exec @cmd; die f_ "exec %s: %s\n", $cmd[0], $!; } while () { chomp; -- cgit v1.2.3