From eebba5982cca5be0436693ca3334fb0b17c4f88a Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Sat, 8 Jul 2017 18:05:36 +0100 Subject: dgit: Cope if the archive server sends an HTTP redirect We achieve this by passing -L to curl. We also pass an appropriate-seeming --proto-redir, because the curl manual is not entirely reassuring that following redirections with the default configuration is safe. This finally fixes #867185/#867309. What happens there is that curl gets a redirect, along with an HTML error document. curl then exits with status zero, effectively pretending that the error document is the resource which was requested. dgit notices that something is wrong because the file does not have the expected cryptographic checksum. I suspect that there are other download problems which would give a similar effect. Sadly the curl manpage doesn't seem to suggest a way to avoid this. At least, dgit will never carry on in such a situation, since it insists that the file has the right hash. And if it does have the right hash we don't really care how it was obtained. Signed-off-by: Ian Jackson --- debian/changelog | 2 ++ 1 file changed, 2 insertions(+) (limited to 'debian') diff --git a/debian/changelog b/debian/changelog index 942c77b..05f08e7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,6 +2,8 @@ dgit (3.11~) unstable; urgency=medium * dgit: fix rpush+buildinfo: Transfer buildinfos for signing. Closes:#867693. + * dgit: Cope if the archive server sends an HTTP redirect, + by passing -L to curl. Closes:#867185,#867309. -- -- cgit v1.2.3