From c4ba5f47ca8674d6212dd9e76a4ee4185e815a75 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Sun, 22 Apr 2018 22:46:28 +0100 Subject: git-debrebase: Do not mind stitching an unlaundered branch I discover that stitch treats non-launderedness as a snag. This is not quite compatible with these newfangled push-your-unlaundered-stuff workflows. It would be possible to make one of prepush or stitch (currently synonyms) behave differently in this respect. do you know why stitch treats non-launderedness as a snag? given that we expect [most people] to use `git debrebase conclude`, which launders, and never invoke `git debrebase stitch` explicitly, it would be okay to change that such that `git debrebase stitch` does not consider non-launderedness to be a snag. I think it does that just because I am the kind of person who thinks, when writing some routine, "what could I check here?" :-) I think you are perhaps right that it ought not to. "conclude" didn't exist then of course. okay. git-debrebase(1) could note "you probably want conclude because you probably want to launder" Mmmm. Signed-off-by: Ian Jackson --- git-debrebase | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'git-debrebase') diff --git a/git-debrebase b/git-debrebase index 5aaa660..c02fe8a 100755 --- a/git-debrebase +++ b/git-debrebase @@ -1316,7 +1316,7 @@ sub cmd_stitch () { my $prose = 'stitch'; GetOptions('prose=s', \$prose) or die badusage("bad options to stitch"); badusage "no arguments allowed" if @ARGV; - do_stitch $prose, \&snag; + do_stitch $prose, 0; } sub cmd_prepush () { cmd_stitch(); } -- cgit v1.2.3