use "better" file IO when finding homepage

1 files changed, 7 insertions, 6 deletions

diff --git a/lib/DhMakeELPA/Command/Packaging.pm b/lib/DhMakeELPA/Command/Packaging.pm
index c2a08df..11c6da6 100644
--- a/lib/DhMakeELPA/Command/Packaging.pm
+++ b/lib/DhMakeELPA/Command/Packaging.pm
@@ -28,16 +28,17 @@ sub extract_basic {
     # of the binary package with the shortest name, then the second
     # shortest etc.  This might leave $self->homepage undefined
     foreach my $bin (sort {length($a) <=> length($b)} keys %{$self->bins}) {
-        # TODO rewrite using $self->_file_r ?
-        my $fh;
-        open $fh, '<', $self->main_dir . "/$bin.el";
-        while (<$fh>) {
-            if (/^;; URL: /) {
+        my $fh = $self->_file_r( $self->main_file("$bin.el") );
+        while (my $line = $fh->getline()) {
+            if ($line =~ /^;; URL: /) {
                 $self->homepage($');
                 last;
             }
         }
-        close $fh;
+        $fh->close;
+        if (defined $self->homepage) {
+            last;
+        }
     }
 }