diff options
| author | Sangjung Woo <sangjung.woo@samsung.com> | 2015-09-08 15:09:40 +0900 |
|---|---|---|
| committer | Sven Eden <yamakuzure@gmx.net> | 2017-03-29 10:45:09 +0200 |
| commit | eeeefb47fde1f010e14c9f0a6104bba011ce9b20 (patch) | |
| tree | 89ba08286dd73e6a4c0b88710eac3164ce762413 | |
| parent | e50b9bfa20b2f3aa0d29a956b1f9307f0e2a0db0 (diff) | |
smack: bugfix the smack label of symlink when '--with-smack-run-label' is set
Even though elogind has its own smack label since
'--with-smack-run-label' configuration is set, the smack label of each
CGROUP root directory should have the star (i.e. *) label. This is
mainly because current Linux Kernel set the label in this way.
(Refer to smack_d_instantiate() in security/smack/smack_lsm.c)
However, if elogind has its own smack label and arg_join_controllers is
explicitly set or initialized by initialize_join_controllers() function,
current elogind creates the symlink in CGROUP root directory with its
own smack label as below.
lrwxrwxrwx. 1 root root System 11 Dec 31 16:00 cpu -> cpu,cpuacct
dr-xr-xr-x. 4 root root * 0 Dec 31 16:01 cpu,cpuacct
lrwxrwxrwx. 1 root root System 11 Dec 31 16:00 cpuacct -> cpu,cpuacct
This patch fixes that bug by copying the smack label from the origin.
| -rw-r--r-- | src/core/mount-setup.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/core/mount-setup.c b/src/core/mount-setup.c index ed95cbbc2..4713187e6 100644 --- a/src/core/mount-setup.c +++ b/src/core/mount-setup.c @@ -322,6 +322,11 @@ int mount_cgroup_controllers(char ***join_controllers) { r = symlink(options, t); if (r < 0 && errno != EEXIST) return log_error_errno(errno, "Failed to create symlink %s: %m", t); +#ifdef SMACK_RUN_LABEL + r = mac_smack_copy(t, options); + if (r < 0 && r != -EOPNOTSUPP) + return log_error_errno(r, "Failed to copy smack label from %s to %s: %m", options, t); +#endif } } } |