diff options
| author | Dave Reisner <dreisner@archlinux.org> | 2013-07-30 12:46:23 -0400 |
|---|---|---|
| committer | Dave Reisner <dreisner@archlinux.org> | 2013-07-30 13:04:46 -0400 |
| commit | a72d698d0d9ff9c158155b44cdc77376df31a317 (patch) | |
| tree | 3c80960a1404b44df57b200208664c206f96d8cf /shell-completion/bash/hostnamectl | |
| parent | 751e75769a0a8a255e1a47656f639768879e9518 (diff) | |
bash-completion: use a better definition of __contains_word
- scope the iterator var
- use the correct, quoted, non-expansion prone positional parameter
notation
- prevent expansion on RHS of comparison
- remove unneeded explicit returns.
This really should be defined only once...
Diffstat (limited to 'shell-completion/bash/hostnamectl')
| -rw-r--r-- | shell-completion/bash/hostnamectl | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/shell-completion/bash/hostnamectl b/shell-completion/bash/hostnamectl index a57bffe15..38ab1344f 100644 --- a/shell-completion/bash/hostnamectl +++ b/shell-completion/bash/hostnamectl @@ -18,9 +18,10 @@ # along with systemd; If not, see <http://www.gnu.org/licenses/>. __contains_word () { - local word=$1; shift - for w in $*; do [[ $w = $word ]] && return 0; done - return 1 + local w word=$1; shift + for w in "$@"; do + [[ $w = "$word" ]] && return + done } _hostnamectl() { |