summaryrefslogtreecommitdiff
path: root/src/login/logind-core.c
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2016-01-11 12:47:14 -0500
committerSven Eden <yamakuzure@gmx.net>2017-05-17 15:22:15 +0200
commit6d1d622bf1f4da725d11cbe5c57a757869ae54c6 (patch)
tree1c34ed1dcf37abf41bb154c3fcedd9fb1bce8b88 /src/login/logind-core.c
parent75cbb152e09780f094d869c5d92d6815442f2900 (diff)
tree-wide: check if errno is greater then zero
gcc is confused by the common idiom of return errno ? -errno : -ESOMETHING and thinks a positive value may be returned. Replace this condition with errno > 0 to help gcc and avoid many spurious warnings. I filed a gcc rfe a long time ago, but it hard to say if it will ever be implemented [1]. Both conventions were used in the codebase, this change makes things more consistent. This is a follow up to bcb161b0230f. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61846
Diffstat (limited to 'src/login/logind-core.c')
-rw-r--r--src/login/logind-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/login/logind-core.c b/src/login/logind-core.c
index c92b38952..be8376822 100644
--- a/src/login/logind-core.c
+++ b/src/login/logind-core.c
@@ -139,7 +139,7 @@ int manager_add_user_by_uid(Manager *m, uid_t uid, User **_user) {
errno = 0;
p = getpwuid(uid);
if (!p)
- return errno ? -errno : -ENOENT;
+ return errno > 0 ? -errno : -ENOENT;
return manager_add_user(m, uid, p->pw_gid, p->pw_name, _user);
}