path: root/src/uaccess-command
diff options
authorAlan Jenkins <>2018-06-01 19:03:21 +0100
committerSven Eden <>2018-08-24 16:47:08 +0200
commita35a95b092b411179028c94fee69139a4afeedfd (patch)
treed37af3630f66e6bc759a75e7ab787a3f04c17ecf /src/uaccess-command
parentb03837e962f32114283c27bf40af7fc4c25fe3cd (diff)
login: log session state "closing" (as well as New/Removed)
Let's show a message at the time of logout i.e. entering the "closing" state, not just e.g. once the user closes `tmux` and the session can be removed completely. (At least when KillUserProcesses=no applies. My thinking was we can spare the log noise if we're killing the processes anyway). These are two independent events. I think the logout event is quite significant in the session lifecycle. It will be easier for a user who does not know logind details to understand why "Removed session" doesn't appear at logout time, if we have a specific message we can show at this time :). Tested using tmux and KillUserProcesses=no. I can also confirm the extra message doesn't show when using KillUserProcesses=yes. Maybe it looks a bit mysterious when you use KillOnlyUsers= / KillExcludeUsers=, but hopefully not alarmingly so. I was looking at systemd-logind messages on my system, because I can reproduce two separate problems with Gnome on Fedora 28 where sessions are unexpectedly in state "closing". (One where a GUI session limps along in a degraded state[1], and another where spice-vdagent is left alive after logout, keeping the session around[2]). It logged when sessions were created and removed, but it didn't log when the session entered the "closing" state. [1] [2] Closes #9096
Diffstat (limited to 'src/uaccess-command')
0 files changed, 0 insertions, 0 deletions