summaryrefslogtreecommitdiff
path: root/src/basic
diff options
context:
space:
mode:
Diffstat (limited to 'src/basic')
-rw-r--r--src/basic/errno-list.c1
-rw-r--r--src/basic/fs-util.c1
-rw-r--r--src/basic/gunicode.c2
-rw-r--r--src/basic/hash-funcs.c2
-rw-r--r--src/basic/hostname-util.h1
-rw-r--r--src/basic/log.c8
-rw-r--r--src/basic/log.h18
-rw-r--r--src/basic/process-util.h1
-rw-r--r--src/basic/random-util.c5
-rw-r--r--src/basic/socket-util.c1
-rw-r--r--src/basic/stat-util.c5
-rw-r--r--src/basic/time-util.c1
-rw-r--r--src/basic/verbs.c2
13 files changed, 32 insertions, 16 deletions
diff --git a/src/basic/errno-list.c b/src/basic/errno-list.c
index ee48332db..256eec086 100644
--- a/src/basic/errno-list.c
+++ b/src/basic/errno-list.c
@@ -18,6 +18,7 @@
along with systemd; If not, see <http://www.gnu.org/licenses/>.
***/
+//#include <errno.h>
#include <string.h>
#include "errno-list.h"
diff --git a/src/basic/fs-util.c b/src/basic/fs-util.c
index 0cd339d29..a03cbfe35 100644
--- a/src/basic/fs-util.c
+++ b/src/basic/fs-util.c
@@ -39,6 +39,7 @@
#include "mkdir.h"
#include "parse-util.h"
#include "path-util.h"
+//#include "process-util.h"
#include "stat-util.h"
#include "stdio-util.h"
#include "string-util.h"
diff --git a/src/basic/gunicode.c b/src/basic/gunicode.c
index e6ac0545a..8aff4a0fc 100644
--- a/src/basic/gunicode.c
+++ b/src/basic/gunicode.c
@@ -4,8 +4,6 @@
* Copyright 2000, 2005 Red Hat, Inc.
*/
-#include <stdlib.h>
-
#include "gunicode.h"
#define unichar uint32_t
diff --git a/src/basic/hash-funcs.c b/src/basic/hash-funcs.c
index e69f81558..1716401d1 100644
--- a/src/basic/hash-funcs.c
+++ b/src/basic/hash-funcs.c
@@ -19,6 +19,8 @@
along with systemd; If not, see <http://www.gnu.org/licenses/>.
***/
+//#include <string.h>
+
#include "hash-funcs.h"
void string_hash_func(const void *p, struct siphash *state) {
diff --git a/src/basic/hostname-util.h b/src/basic/hostname-util.h
index c10ba3261..37fb56004 100644
--- a/src/basic/hostname-util.h
+++ b/src/basic/hostname-util.h
@@ -21,6 +21,7 @@
***/
#include <stdbool.h>
+//#include <stdio.h>
#include "macro.h"
diff --git a/src/basic/log.c b/src/basic/log.c
index 43cb70096..5bbf65a4a 100644
--- a/src/basic/log.c
+++ b/src/basic/log.c
@@ -1260,7 +1260,6 @@ void log_received_signal(int level, const struct signalfd_siginfo *si) {
log_full(level,
"Received SIG%s.",
signal_to_string(si->ssi_signo));
-
}
#endif // 0
@@ -1324,3 +1323,10 @@ void log_set_always_reopen_console(bool b) {
void log_set_open_when_needed(bool b) {
open_when_needed = b;
}
+
+int log_emergency_level(void) {
+ /* Returns the log level to use for log_emergency() logging. We use LOG_EMERG only when we are PID 1, as only
+ * then the system of the whole system is obviously affected. */
+
+ return getpid_cached() == 1 ? LOG_EMERG : LOG_ERR;
+}
diff --git a/src/basic/log.h b/src/basic/log.h
index 297bb92b9..3bcc87766 100644
--- a/src/basic/log.h
+++ b/src/basic/log.h
@@ -20,18 +20,16 @@
along with systemd; If not, see <http://www.gnu.org/licenses/>.
***/
-#include <errno.h>
#include <stdarg.h>
#include <stdbool.h>
#include <stdlib.h>
-#include <sys/signalfd.h>
-#include <sys/socket.h>
#include <syslog.h>
-#include "sd-id128.h"
-
#include "macro.h"
-#include "process-util.h"
+
+/* Some structures we reference but don't want to pull in headers for */
+struct iovec;
+struct signalfd_siginfo;
typedef enum LogRealm {
LOG_REALM_SYSTEMD,
@@ -196,7 +194,7 @@ int log_struct_iovec_internal(
const char *file,
int line,
const char *func,
- const struct iovec input_iovec[],
+ const struct iovec *input_iovec,
size_t n_input_iovec);
/* This modifies the buffer passed! */
@@ -254,13 +252,15 @@ void log_assert_failed_return_realm(
#define log_full(level, ...) log_full_errno((level), 0, __VA_ARGS__)
+int log_emergency_level(void);
+
/* Normal logging */
#define log_debug(...) log_full(LOG_DEBUG, __VA_ARGS__)
#define log_info(...) log_full(LOG_INFO, __VA_ARGS__)
#define log_notice(...) log_full(LOG_NOTICE, __VA_ARGS__)
#define log_warning(...) log_full(LOG_WARNING, __VA_ARGS__)
#define log_error(...) log_full(LOG_ERR, __VA_ARGS__)
-#define log_emergency(...) log_full(getpid_cached() == 1 ? LOG_EMERG : LOG_ERR, __VA_ARGS__)
+#define log_emergency(...) log_full(log_emergency_level(), __VA_ARGS__)
/* Logging triggered by an errno-like error */
#define log_debug_errno(error, ...) log_full_errno(LOG_DEBUG, error, __VA_ARGS__)
@@ -268,7 +268,7 @@ void log_assert_failed_return_realm(
#define log_notice_errno(error, ...) log_full_errno(LOG_NOTICE, error, __VA_ARGS__)
#define log_warning_errno(error, ...) log_full_errno(LOG_WARNING, error, __VA_ARGS__)
#define log_error_errno(error, ...) log_full_errno(LOG_ERR, error, __VA_ARGS__)
-#define log_emergency_errno(error, ...) log_full_errno(getpid_cached() == 1 ? LOG_EMERG : LOG_ERR, error, __VA_ARGS__)
+#define log_emergency_errno(error, ...) log_full_errno(log_emergency_level(), error, __VA_ARGS__)
#ifdef LOG_TRACE
# define log_trace(...) log_debug(__VA_ARGS__)
diff --git a/src/basic/process-util.h b/src/basic/process-util.h
index 652e4c341..7942d36e6 100644
--- a/src/basic/process-util.h
+++ b/src/basic/process-util.h
@@ -21,6 +21,7 @@
***/
#include <alloca.h>
+//#include <errno.h>
#include <sched.h>
#include <signal.h>
#include <stdbool.h>
diff --git a/src/basic/random-util.c b/src/basic/random-util.c
index 1bc800089..127c4522b 100644
--- a/src/basic/random-util.c
+++ b/src/basic/random-util.c
@@ -21,11 +21,12 @@
#include <elf.h>
#include <errno.h>
#include <fcntl.h>
+//#include <linux/random.h>
#include <stdbool.h>
+//#include <stdint.h>
#include <stdlib.h>
+//#include <string.h>
#include <sys/time.h>
-#include <linux/random.h>
-#include <stdint.h>
#if HAVE_SYS_AUXV_H
# include <sys/auxv.h>
diff --git a/src/basic/socket-util.c b/src/basic/socket-util.c
index c170e7432..d89136b01 100644
--- a/src/basic/socket-util.c
+++ b/src/basic/socket-util.c
@@ -41,6 +41,7 @@
#include "missing.h"
#include "parse-util.h"
#include "path-util.h"
+//#include "process-util.h"
#include "socket-util.h"
#include "string-table.h"
#include "string-util.h"
diff --git a/src/basic/stat-util.c b/src/basic/stat-util.c
index 064e316fc..964fa91b2 100644
--- a/src/basic/stat-util.c
+++ b/src/basic/stat-util.c
@@ -21,10 +21,11 @@
#include <dirent.h>
#include <errno.h>
#include <fcntl.h>
-#include <sys/stat.h>
-#include <sys/types.h>
#include <linux/magic.h>
+//#include <sched.h>
+//#include <sys/stat.h>
#include <sys/statvfs.h>
+//#include <sys/types.h>
#include <unistd.h>
#include "dirent-util.h"
diff --git a/src/basic/time-util.c b/src/basic/time-util.c
index 98324c234..dc387d8b7 100644
--- a/src/basic/time-util.c
+++ b/src/basic/time-util.c
@@ -38,6 +38,7 @@
#include "macro.h"
#include "parse-util.h"
#include "path-util.h"
+//#include "process-util.h"
#include "string-util.h"
#include "strv.h"
#include "time-util.h"
diff --git a/src/basic/verbs.c b/src/basic/verbs.c
index 4f17d39f8..f2e9f29d6 100644
--- a/src/basic/verbs.c
+++ b/src/basic/verbs.c
@@ -22,10 +22,12 @@
#include <getopt.h>
#include <stdbool.h>
#include <stddef.h>
+//#include <string.h>
//#include "env-util.h"
#include "log.h"
#include "macro.h"
+//#include "process-util.h"
#include "string-util.h"
#include "verbs.h"
#include "virt.h"