| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
|
| |
It is redundant to store 'hash' and 'compare' function pointers in
struct Hashmap separately. The functions always comprise a pair.
Store a single pointer to struct hash_ops instead.
systemd keeps hundreds of hashmaps, so this saves a little bit of
memory.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getopt is usually good at printing out a nice error message when
commandline options are invalid. It distinguishes between an unknown
option and a known option with a missing arg. It is better to let it
do its job and not use opterr=0 unless we actually want to suppress
messages. So remove opterr=0 in the few places where it wasn't really
useful.
When an error in options is encountered, we should not print a lengthy
help() and overwhelm the user, when we know precisely what is wrong
with the commandline. In addition, since help() prints to stdout, it
should not be used except when requested with -h or --help.
Also, simplify things here and there.
|
| |
|
|
|
|
|
| |
If -flto is used then gcc will generate a lot more warnings than before,
among them a number of use-without-initialization warnings. Most of them
without are false positives, but let's make them go away, because it
doesn't really matter.
|
| | |
|
| |
|
|
|
| |
Among other things this makes sure we always expose a --version command
and show it in the help texts.
|
| |
|
|
|
|
| |
This extends 62678ded 'efi: never call qsort on potentially
NULL arrays' to all other places where qsort is used and it
is not obvious that the count is non-zero.
|
| |
|
|
|
| |
The online help shows the keys as uppercase but the code and manpage say
lower case. Make the online help follow reality.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Instead of outputting "5h 55s 50ms 3us" we'll now output "5h
55.050003s". Also, while outputting the accuracy is configurable.
Basically we now try use "dot notation" for all time values > 1min. For
>= 1s we use 's' as unit, otherwise for >= 1ms we use 'ms' as unit, and
finally 'us'.
This should give reasonably values in most cases.
|
| |
|
|
|
|
|
|
| |
Internally we store all time values in usec_t, however parse_usec()
actually was used mostly to parse values in seconds (unless explicit
units were specified to define a different unit). Hence, be clear about
this and name the function about what we pass into it, not what we get
out of it.
|
| | |
|
| | |
|
| |
|
|
| |
use default depth from variable for --help
|
| |
|
|
|
|
|
| |
Also split out some fileio functions to fileio.c and provide a SELinux
aware pendant in fileio-label.c
see https://bugzilla.redhat.com/show_bug.cgi?id=881577
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Return codes in systemd are negated and
if (r < 0) if (r == ENOENT)
was never true.
|
| |
|
|
|
|
|
| |
Adds messages for formally silent errors: new "Failed on cmdline argument %s: %s".
Removes some specific error messages for -ENOMEM in mount-setup.c. A few specific
ones have been left in other binaries.
|
| | |
|
| | |
|
| |
|
|
| |
[zj: use static]
|
| | |
|
| |
|
|
|
|
| |
also a number of minor fixups and bug fixes: spelling, oom errors
that didn't print errors, not properly forwarding error codes,
few more consistency issues, et cetera
|
| |
|
|
|
|
|
|
| |
glibc/glib both use "out of memory" consistantly so maybe we should
consider that instead of this.
Eliminates one string out of a number of binaries. Also fixes extra newline
in udev/scsi_id
|
| |
|
|
| |
This is to match strappend() and the other string related functions.
|
| |
|
|
|
| |
cgtop quits on startup if all the cgroup mounts it expects are not available.
Just continue without nonexistant ones.
|
| |
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=49778
|
| | |
|
| |
|
