| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
| |
The timeouts in the networking library (DHCP lease timeouts and similar) should not be affected
by suspend. In the cases where CLOCK_BOOTTIME is not implemented, it is still safe to fallback to
CLOCK_MONOTONIC, as the consumers of the library (i.e., networkd) _should_ renew the leases when
coming out of suspend.
|
| |
|
|
|
|
| |
Check that received DHCP packets actually include our MAC address in
chaddr field. BPF interpreter has 32 bit wide registers but MAC address
is 48 bits long so we have to do check in two steps.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
For efficiency, we group bytes together before adding them up. This
is guaranteed to always work (regardless of the byte order) as long
as the i-th byte in each group lign up with the i-th byte in each
other group.
On big-endian machines this broke when handling the trailing few bytes
which did not make up a full group of 4 bytes. This patch fixes the
problem by explicitly creating a 4 byte zero-padded group out of the
trailing bytes.
Reported and tested by Thomas Ritter <th.ritter@gmx.at>.
|
| |
|
|
|
| |
UDP sockets can anyway not be bound to specific netdev's. The packages would have to be filtered
when received instead.
|
| |
|
|
|
|
|
|
| |
- Also only allow positive ifindex on both dhcp and ipv4ll
[tomegun: the kernel always sets a positive ifindex, but some APIs accept
ifindex=0 with various meanings, so we should protect against
accidentally passing ifindex=0 along.]
|
| |
|
|
|
| |
Also unref client objects in test code, and initalize logging,
to DEBUG by default.
|
| |
|
|
|
|
|
|
|
|
|
| |
The DHCP library user can decide to free the DHCP client any time
the callback is called. After the callback has been called, other
computations may still be needed - the best example being a full
restart of the DHCP procedure in case of lease expiry.
Fix this by introducing proper reference counting. Properly handle
a returned NULL from the notify and stop functions if the DHCP
client was freed.
|
| |
|
|
|
|
| |
This test should have been updated when changing the magic cookie handling around.
Reported by Ken MacLeod.
|
| | |
|
| |
|
|
|
|
| |
Try a bit harder to make the kernel drop packets not for us. This should reduce
the number of wakeups from n^2 to n in the number of dhcp clients, which admittedly
only makes a differenc in very extreme cases.
|
| |
|
|
| |
CLOCK_BOOTTIME_ALARM, too
|
| |
|
|
|
| |
One end of the socketpair is closed by the library, so only close our end. Also switch to
the safe_close() so we get notified about problems with closing.
|
| |
|
|
|
| |
Check that the client identifier is formatted as suggested in the
RFC and that the messages sent ends with an end option.
|
| | |
|
| |
|
|
|
| |
Remove identical checksum function implementation from the test
case code.
|
| | |
|
| | |
|
|
|
This is similar to sd-login, but exposes the state of networkd rather than logind.
Include it in libsystemd-dhcp and rename it to libsystemd-network.
|
