summaryrefslogtreecommitdiff
path: root/src/test/test-util.c
Commit message (Collapse)AuthorAge
...
* test: fix strtod() testDavid Herrmann2014-08-15
| | | | | | | | | | | | | | | One strtod() test is broken since: commit 8e211000025940b770794abf5754de61b4add0af Author: Thomas Hindoe Paaboel Andersen <phomes@gmail.com> Date: Mon Aug 4 23:13:31 2014 +0200 test: use fabs on doubles The commit was right, so no reason to revert it, but the test was broken before and only worked by coincidence. Convert "0,5" to "0.5" so we don't depend on locales for double conversion (or well, we depend on "C" which seems reasonable).
* util: allow strappenda to take any number of argsDave Reisner2014-08-13
| | | | | This makes strappenda3 redundant, so we remove its usage and definition. Add a few tests along the way for sanity.
* test: use fabs on doublesThomas Hindoe Paaboel Andersen2014-08-04
|
* Properly report invalid quoted stringsZbigniew Jędrzejewski-Szmek2014-07-31
| | | | | | | | $ systemd-analyze verify trailing-g.service [./trailing-g.service:2] Trailing garbage, ignoring. trailing-g.service lacks ExecStart setting. Refusing. Error: org.freedesktop.systemd1.LoadFailed: Unit trailing-g.service failed to load: Invalid argument. Failed to create trailing-g.service/start: Invalid argument
* Reject invalid quoted stringsZbigniew Jędrzejewski-Szmek2014-07-31
| | | | | | | | | | | | | | | | | | | | | | String which ended in an unfinished quote were accepted, potentially with bad memory accesses. Reject anything which ends in a unfished quote, or contains non-whitespace characters right after the closing quote. _FOREACH_WORD now returns the invalid character in *state. But this return value is not checked anywhere yet. Also, make 'word' and 'state' variables const pointers, and rename 'w' to 'word' in various places. Things are easier to read if the same name is used consistently. mbiebl_> am I correct that something like this doesn't work mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-passwd "Unlock EncFS"' mbiebl_> systemd seems to strip of the quotes mbiebl_> systemctl status shows mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-password Unlock EncFS $RootDir $MountPoint mbiebl_> which is pretty weird
* parse_boolean: require exact matchesAnsgar Burchardt2014-07-27
| | | | | | | | | | Require exact matches in all cases instead of treating strings starting with 't' ('f') as true (false). This is required for config_parse_protect_system to parse ProtectSystem=full correctly: it uses parse_boolean and only tries a more specific parsing function if that did not return a valid result. Thus "full" was treated as "false" before.
* util: fix has cc check and add testZbigniew Jędrzejewski-Szmek2014-07-11
|
* util: when unescaping strings, don't allow smuggling in of additional NUL bytesLennart Poettering2014-07-02
| | | | Better safe than sorry.
* tests: add tests to test-utilRonny Chevalier2014-06-19
| | | | | | | | | | | | | | | | add tests for: - filename_is_safe - ascii_strlower - files_same - is_valid_documentation_url - file_in_same_dir - endswith - close_nointr - unlink_noerrno - readlink_and_make_absolute - read_one_char - ignore_signals - strshorten
* tests: unlink temp file used in testRonny Chevalier2014-06-16
|
* Remove unnecessary casts in printfsZbigniew Jędrzejewski-Szmek2014-05-15
| | | | No functional change expected :)
* shared: add ALIGN_POWER2 macroDavid Herrmann2014-05-13
| | | | | | Sounds easy, turns out to be horrible to implement: ALIGN_POWER2 returns the next higher power of 2. clz(0) is undefined, same is true for left-shift-overflows, yey, C rocks!
* util: add new FOREACH_STRING() macro as syntactic sugar to iterate through a ↵Lennart Poettering2014-03-19
| | | | number of fixed strings
* util: replace close_nointr_nofail() by a more useful safe_close()Lennart Poettering2014-03-18
| | | | | | | | | | | | | | | safe_close() automatically becomes a NOP when a negative fd is passed, and returns -1 unconditionally. This makes it easy to write lines like this: fd = safe_close(fd); Which will close an fd if it is open, and reset the fd variable correctly. By making use of this new scheme we can drop a > 200 lines of code that was required to test for non-negative fds or to reset the closed fd variable afterwards.
* timedated: use builtins for integer log and expZbigniew Jędrzejewski-Szmek2014-03-14
|
* util: add hexdump() call to create pretty hexdumps of dataLennart Poettering2014-03-14
| | | | This is very useful when debugging sd-bus to look at messages.
* macro: make sure we can use IN_SET() also with complex function calls as ↵Lennart Poettering2014-03-12
| | | | first argument
* Disallow sizes with increasing unit sizeZbigniew Jędrzejewski-Szmek2014-03-02
| | | | | | | | | Things like 3B4T, 4B50B, 400 100 (meaning 4*1024**4+3, 54, and 500, respectively) are now disallowed. It is necessary to say 4T3B, 54B, 500 instead. I think this was confusing and error prone. As a special form, 400B 100 is allowed, i.e. "B" suffix is treated as different from "", although they mean the same thing.
* Allow fractional parts in disk sizesZbigniew Jędrzejewski-Szmek2014-03-02
| | | | | | It seems natural to be able to say SystemMaxUsage=1.5G. https://bugzilla.redhat.com/show_bug.cgi?id=1047568
* core: clean up some confusing regarding SI decimal and IEC binary suffixes ↵Lennart Poettering2014-02-23
| | | | | | | | | | | for sizes According to Wikipedia it is customary to specify hardware metrics and transfer speeds to the basis 1000 (SI decimal), while software metrics and physical volatile memory (RAM) sizes to the basis 1024 (IEC binary). So far we specified everything in IEC, let's fix that and be more true to what's otherwise customary. Since we don't want to parse "Mi" instead of "M" we document each time what the context used is.
* make gcc shut upLennart Poettering2014-02-19
| | | | | | | If -flto is used then gcc will generate a lot more warnings than before, among them a number of use-without-initialization warnings. Most of them without are false positives, but let's make them go away, because it doesn't really matter.
* util: drop parse_user_at_host() since its unused nowLennart Poettering2014-02-11
|
* Get rid of write_safeZbigniew Jędrzejewski-Szmek2014-01-28
| | | | | | Current glibc implementation is safe. Kernel does this atomically, and write is actually implemented through writev. So if write is async-signal-safe, than writev pretty much must be too.
* always use the same code for creating temporary filesLennart Poettering2014-01-28
| | | | Let's unify our code here, and also always specifiy O_CLOEXEC.
* journal: guarantee async-signal-safety in sd_journald_sendvZbigniew Jędrzejewski-Szmek2014-01-27
| | | | | | | | | | | | | | | | | | signal(7) provides a list of functions which may be called from a signal handler. Other functions, which only call those functions and don't access global memory and are reentrant are also safe. sd_j_sendv was mostly OK, but would call mkostemp and writev in a fallback path, which are unsafe. Being able to call sd_j_sendv in a async-signal-safe way is important because it allows it be used in signal handlers. Safety is achieved by replacing mkostemp with open(O_TMPFILE) and an open-coded writev replacement which uses write. Unfortunately, O_TMPFILE is only available on kernels >= 3.11. When O_TMPFILE is unavailable, an open-coded mkostemp is used. https://bugzilla.gnome.org/show_bug.cgi?id=722889
* macro: add a macro to test whether a value is in a specified listLennart Poettering2013-12-02
| | | | | | | | | | | | | | | Introduce IN_SET() macro to nicely check whether a value a is one of a few listed values. This makes writing this: if (a == 1 || a == 7 || a == 8 || a == 9) nicer, by allowing this: if (IN_SET(a, 1, 7, 8, 9)) This is particularly useful for state machine enums.
* bus: add API calls to escape string components of objects pathsLennart Poettering2013-11-21
|
* tests: fix some memory leaks in testsLennart Poettering2013-10-09
|
* Fix buffer overrun when enumerating filesZbigniew Jędrzejewski-Szmek2013-09-29
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=69887 Based-on-a-patch-by: Hans Petter Jansson <hpj@copyleft.no>
* Use udev_encode_string in fstab_node_to_udev_nodeDave Reisner2013-09-17
| | | | | Resolves a longstanding bug which caused this function to wrongly handle (escape) valid utf8 characters.
* test: Make testing work on systems without or old systemdHolger Hans Peter Freyther2013-08-22
| | | | | | | | | | | | | | * Introduce a macro to conditionally execute tests. This avoids skipping the entire test if some parts require systemd * Skip the journal tests when no /etc/machine-id is present * Change test-catalog to load the catalog from the source directory of systemd. * /proc/PID/comm got introduced in v2.6.33 but travis is still using v2.6.32. * Enable make check and make distcheck on the travis build * Use -D"CATALOG_DIR=STR($(abs_top_srcdir)/catalog)" as a STRINGIY would result in the path '/home/ich/source/linux' to be expanded to '/home/ich/source/1' as linux is defined to 1.
* tests: fix indentationThomas Hindoe Paaboel Andersen2013-08-15
|
* util: add split_pair() for splitting foo=bar stringsLennart Poettering2013-07-18
|
* tests: add more tests for shared/util.cThomas Hindoe Paaboel Andersen2013-07-16
|
* Properly check for overflow in offsetsZbigniew Jędrzejewski-Szmek2013-06-10
|
* Use attribute(unused) in PROTECT_ERRNOZbigniew Jędrzejewski-Szmek2013-04-25
| | | | | | | clang emits warnings about unused attribute _saved_errno_, which drown out other—potentially useful—warnings. gcc documentation is not exactly verbose about the effects of __attribute__((unused)) on variables, but let's assume that it works if the unit test passes.
* util: rework safe_atod() to be locale-independentLennart Poettering2013-04-25
| | | | | This adds some syntactic sugar with a macro RUN_WITH_LOCALE() that reset the thread-specific locale temporarily.
* util: make generation of profcs PID paths nicerLennart Poettering2013-04-16
|
* journal: u64log2 can be expressed just as __builtin_clzll(n) ^ 63UCristian Rodríguez2013-04-05
|
* util: be more picky when validating hostnamesLennart Poettering2013-03-22
| | | | | | | No longer allow dots at the beginning or end of host names, Or double dots. https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1152187/comments/14
* test-util: add more testsThomas Hindoe Paaboel Andersen2013-03-07
| | | | | | Improve test coverage a bit with tests for close_many strappend (to cover all ways through strnappend)
* util: properly escape corner cases in bus_path_escape(), tooLennart Poettering2013-03-05
| | | | | | This follows the suggestions from: http://lists.freedesktop.org/archives/systemd-devel/2013-March/009363.html
* test-util.c: added hexchar, unhexchar, octchar, unoctchar, decchar, ↵Daniel Buch2013-02-26
| | | | undecchar tests
* tests: add a few more tests to test-util.cThomas Hindoe Paaboel Andersen2013-02-25
| | | | | | | | | Add asserts on the resutls in FOREACH_WORD_QUOTED Added tests for: FOREACH_WORD strstrip delete_chars in_charset
* tests: more tests for util.cThomas Hindoe Paaboel Andersen2013-02-20
| | | | | | | | tests for: test_parse_pid test_parse_uid test_safe_atolli test_safe_atod
* tests: add test of memdup_multiplyThomas Hindoe Paaboel Andersen2013-02-18
|
* tests: more testsThomas Hindoe Paaboel Andersen2013-02-11
| | | | | | | | | tests for: parse_boolean env_name_is_valid Also convert assert to assert_se to make sure they are run even with optimization. (see commit 9b5d6bd909855543cba75a4469bff6f82845cf0d)
* test: add a few tests and tidy upThomas Hindoe Paaboel Andersen2013-02-06
adds test of: strv_find strv_find_prefix strv_overlap strv_sort streq_ptr first_word Splits tests of util.c into own file to avoid clutter as we add more. Removed a few prints and uses _cleanup_free_ to make the tests more focused.
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-17 04:07:10 +0000