From ff391acf2c61fec39a5260ad9b279d810ee78bc0 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 25 Sep 2018 12:02:26 +0200 Subject: exec-util: handle putenv() errors Just paranoia, as putenv() can fail and we should catch it, like we catch all other errors. Follow-up for #10073 (cherry picked from commit ed689f7894e56024a11bd02327b2bdfce5636dfd) --- src/basic/exec-util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/basic/exec-util.c') diff --git a/src/basic/exec-util.c b/src/basic/exec-util.c index cfb082a03..468c247c6 100644 --- a/src/basic/exec-util.c +++ b/src/basic/exec-util.c @@ -102,7 +102,8 @@ static int do_execute( alarm(DIV_ROUND_UP(timeout, USEC_PER_SEC)); STRV_FOREACH(e, envp) - putenv(*e); + if (putenv(*e) < 0) + return log_error_errno(errno, "Failed to set environment variable: %m"); STRV_FOREACH(path, paths) { _cleanup_free_ char *t = NULL; -- cgit v1.2.3