From 7b77ed8cf36e8eca6017791626044b61ae2d68e7 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 13 Dec 2013 03:30:42 +0100 Subject: event: be more conservative when returning errors from event handler callbacks We really should return errors from event handlers if we have a continous problem and don't know any other solution. --- src/journal/journald-stream.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/journal/journald-stream.c') diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c index 8958c7f3d..aba9054b2 100644 --- a/src/journal/journald-stream.c +++ b/src/journal/journald-stream.c @@ -293,7 +293,6 @@ static int stdout_stream_process(sd_event_source *es, int fd, uint32_t revents, if ((revents|EPOLLIN|EPOLLHUP) != (EPOLLIN|EPOLLHUP)) { log_error("Got invalid event from epoll for stdout stream: %"PRIx32, revents); - r = -EIO; goto terminate; } @@ -304,12 +303,11 @@ static int stdout_stream_process(sd_event_source *es, int fd, uint32_t revents, return 0; log_warning("Failed to read from stream: %m"); - r = -errno; goto terminate; } if (l == 0) { - r = stdout_stream_scan(s, true); + stdout_stream_scan(s, true); goto terminate; } @@ -391,7 +389,6 @@ static int stdout_stream_new(sd_event_source *es, int listen_fd, uint32_t revent len = sizeof(stream->ucred); if (getsockopt(fd, SOL_SOCKET, SO_PEERCRED, &stream->ucred, &len) < 0) { log_error("Failed to determine peer credentials: %m"); - r = -errno; goto fail; } @@ -404,7 +401,6 @@ static int stdout_stream_new(sd_event_source *es, int listen_fd, uint32_t revent if (shutdown(fd, SHUT_WR) < 0) { log_error("Failed to shutdown writing side of socket: %m"); - r = -errno; goto fail; } @@ -428,7 +424,7 @@ static int stdout_stream_new(sd_event_source *es, int listen_fd, uint32_t revent fail: stdout_stream_free(stream); - return r; + return 0; } int server_open_stdout_socket(Server *s) { -- cgit v1.2.3