From 519f9a1ceb7616e830ac40105561350696132316 Mon Sep 17 00:00:00 2001
From: Fernando Farfan <fernando@endlessm.com>
Date: Thu, 13 Jun 2013 07:35:43 -0700
Subject: Addressed code review comments.

Addressed @ptomato comments as follows:
 - Removed white color for topbar labels
 - Corrected document blocks
[endlessm/eos-sdk#97]
---
 endless/eostopbar.c | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

(limited to 'endless')

diff --git a/endless/eostopbar.c b/endless/eostopbar.c
index f72d0a4..67918e6 100644
--- a/endless/eostopbar.c
+++ b/endless/eostopbar.c
@@ -164,7 +164,7 @@ eos_top_bar_new (void)
   return GTK_WIDGET (g_object_new (EOS_TYPE_TOP_BAR, NULL));
 }
 
-/**
+/*
  * eos_top_bar_set_left_widget:
  * @self: the top bar
  * @left_top_bar_widget: the left top bar widget to be set
@@ -189,13 +189,8 @@ eos_top_bar_set_left_widget (EosTopBar *self,
   priv->left_top_bar_widget = left_top_bar_widget;
   if (left_top_bar_widget)
     {
-      // Override font color 
-      GdkRGBA white = { 1.0, 1.0, 1.0, 1.0 };
       gtk_widget_set_halign (GTK_WIDGET (left_top_bar_widget), GTK_ALIGN_CENTER);
       gtk_widget_set_valign (GTK_WIDGET (left_top_bar_widget), GTK_ALIGN_CENTER);
-      gtk_widget_override_color (GTK_WIDGET (left_top_bar_widget),
-                                 GTK_STATE_FLAG_NORMAL,
-                                 &white);
 
       gtk_box_pack_start (GTK_BOX (priv->actions_hbox),
                           left_top_bar_widget,
@@ -204,11 +199,11 @@ eos_top_bar_set_left_widget (EosTopBar *self,
 }
 
 /*
- * eos_top_bar_set_left_widget:
+ * eos_top_bar_set_center_widget:
  * @self: the top bar
- * @left_top_bar_widget: the left top bar widget to be set
+ * @center_top_bar_widget: the center top bar widget to be set
  * 
- * Sets the left widget in the top bar.
+ * Sets the center widget in the top bar.
  */
 void
 eos_top_bar_set_center_widget (EosTopBar *self,
@@ -228,14 +223,9 @@ eos_top_bar_set_center_widget (EosTopBar *self,
   priv->center_top_bar_widget = center_top_bar_widget;
   if (center_top_bar_widget)
     {
-      // Add white foreground to make label actually visible
-      GdkRGBA white = { 1.0, 1.0, 1.0, 1.0 };
       gtk_widget_set_halign (GTK_WIDGET (center_top_bar_widget), GTK_ALIGN_CENTER);
       gtk_widget_set_valign (GTK_WIDGET (center_top_bar_widget), GTK_ALIGN_CENTER);
       gtk_widget_set_hexpand (GTK_WIDGET (center_top_bar_widget), TRUE);
-      gtk_widget_override_color (GTK_WIDGET (center_top_bar_widget),
-                                 GTK_STATE_FLAG_NORMAL,
-                                 &white);
 
       gtk_box_pack_start (GTK_BOX (priv->actions_hbox),
                           center_top_bar_widget,
-- 
cgit v1.2.3