Improve fread error handling in ff2*

In case of unexpected end of file errno is not set, and strerror(errno)
returns "Success". Caller should distinguish between error and EOF by
calling ferror(3) as described in fread(3).

1 files changed, 5 insertions, 2 deletions

diff --git a/ff2png.c b/ff2png.c
index 4304bbb..5731082 100644
--- a/ff2png.c
+++ b/ff2png.c
@@ -81,8 +81,11 @@ main(int argc, char *argv[])
 
 	return 0;
 readerr:
-	fprintf(stderr, "%s: fread: ", argv0);
-	perror(NULL);
+	if (ferror(stdin)) {
+		fprintf(stderr, "%s: fread: %s\n", argv0, strerror(errno));
+	} else {
+		fprintf(stderr, "%s: unexpected end of file\n", argv0);
+	}
 
 	return 1;
 }