summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrlar <rlar>2016-02-28 10:36:06 +0100
committerWill Estes <westes575@gmail.com>2016-03-12 14:16:46 -0500
commit48152721a0591f3bdb4a96c4dc12bb210685151c (patch)
treeab46e249ee3eee749d478c31b0b2b74100b13d63
parentbdc999cbc1b2e5e45af661849175dce5fe1c4036 (diff)
scan.l, rewrite two loops to avoid unneccesairy casting
-rw-r--r--src/scan.l20
1 files changed, 11 insertions, 9 deletions
diff --git a/src/scan.l b/src/scan.l
index 65bdf89..6c1985b 100644
--- a/src/scan.l
+++ b/src/scan.l
@@ -78,8 +78,10 @@ extern const char *escaped_qstart, *escaped_qend;
return NAME;
#define PUT_BACK_STRING(str, start) \
- for ( i = strlen( str ) - 1; i >= start; --i ) \
- unput((str)[i])
+ { size_t i = strlen( str ); \
+ while ( i > start ) \
+ unput((str)[--i]); \
+ }
#define CHECK_REJECT(str) \
if ( all_upper( str ) ) \
@@ -134,7 +136,7 @@ M4QEND "]]"
static int option_sense;
int doing_codeblock = false;
- int i, brace_depth=0, brace_start_line=0;
+ int brace_depth=0, brace_start_line=0;
char nmdef[MAXLINE];
@@ -301,12 +303,12 @@ M4QEND "]]"
FLEX_EXIT(EXIT_FAILURE);
}
/* Skip trailing whitespace. */
- for ( i = strlen( nmdef ) - 1;
- i >= 0 && (nmdef[i] == ' ' || nmdef[i] == '\t');
- --i )
- ;
-
- nmdef[i + 1] = '\0';
+ {
+ size_t i = strlen( nmdef );
+ while (i > 0 && (nmdef[i-1] == ' ' || nmdef[i-1] == '\t'))
+ --i;
+ nmdef[i] = '\0';
+ }
ndinstal( nmstr, nmdef );
didadef = true;