summaryrefslogtreecommitdiff
path: root/helm.el
diff options
context:
space:
mode:
authorThierry Volpiatto <thierry.volpiatto@gmail.com>2017-07-17 14:44:51 +0200
committerThierry Volpiatto <thierry.volpiatto@gmail.com>2017-07-17 14:44:51 +0200
commit9e1dd88f060394ecb9f18f45921888e55c91ccb7 (patch)
treeda0355f5a0fc0a47666914f7947e558e28247c15 /helm.el
parent07f8f705f54506da537b1f615ee2e95e9033defb (diff)
Fix previous commit
The helm-buffer should be erased even if no results * helm.el (helm-update): Do it.
Diffstat (limited to 'helm.el')
-rw-r--r--helm.el22
1 files changed, 11 insertions, 11 deletions
diff --git a/helm.el b/helm.el
index 77e72b7c..e50f01d7 100644
--- a/helm.el
+++ b/helm.el
@@ -3693,19 +3693,19 @@ without recomputing them, it should be a list of lists."
(setq matches (or candidates (helm--collect-matches sources))))
;; If computing matches finished and is not interrupted
;; erase the helm-buffer and render results (Fix #1157).
- (when (or async ;; Always render async sources.
- (cl-loop for sm in matches
- thereis sm))
- (erase-buffer) ;; [1]
- (cl-loop for src in sources
- for mtc in matches
- do (helm-render-source src mtc))
- ;; Move to first line only when there is matches
- ;; to avoid cursor moving upside down (issue #1703).
- (helm--update-move-first-line)
- (helm--reset-update-flag))))
+ (erase-buffer) ;; [1]
+ (cl-loop for src in sources
+ for mtc in matches
+ do (helm-render-source src mtc))
+ ;; Move to first line only when there is matches
+ ;; to avoid cursor moving upside down (issue #1703).
+ (helm--update-move-first-line)
+ (helm--reset-update-flag)))
(let ((src (or source (helm-get-current-source))))
(unless async
+ ;; When there is an async source present among other sync
+ ;; sources run `helm-after-update-hook' in output filter
+ ;; i.e wait the async source finish before running hook.
(helm-display-mode-line src)
(helm-log-run-hook 'helm-after-update-hook)))
(when preselect